Bug 218070 - [WebAuthn] Make WebContent process talk to the WebAuthn process for WebAuthn requests
Summary: [WebAuthn] Make WebContent process talk to the WebAuthn process for WebAuthn ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks: 181943
  Show dependency tree / graph
 
Reported: 2020-10-21 22:44 PDT by Jiewen Tan
Modified: 2020-10-29 14:10 PDT (History)
3 users (show)

See Also:

Attachments
Patch (55.08 KB, patch)
2020-10-21 22:55 PDT, Jiewen Tan 		bfulgham: review+
Details | Formatted Diff | Diff
Patch for landing (55.11 KB, patch)
2020-10-29 13:27 PDT, Jiewen Tan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2020-10-21 22:44:15 PDT 
Make WebContent process talk to the WebAuthn process for WebAuthn requests.
Comment 1 Jiewen Tan 2020-10-21 22:44:30 PDT 
<rdar://problem/70384404>
Comment 2 Jiewen Tan 2020-10-21 22:55:08 PDT 
Created attachment 412069 [details]
Patch
Comment 3 Brent Fulgham 2020-10-29 10:33:24 PDT 
Comment on attachment 412069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412069&action=review

I had a few suggestions, but looks good. r=me

> Source/WebKit/Scripts/process-entitlements.sh:317
> +#    elif [[ "${PRODUCT_NAME}" == com.apple.WebKit.WebAuthn ]]; then ios_family_process_webauthn_entitlements

Did you mean to have this commented out?

If so, please include a # FIXME() comment with the bug number to enable it.

> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:168
> +    // If so, continue to the old route. Otherwise, use the modern WebAuthn process way.

I suggest a FIXME bug here to remove this code once we cut-over to the modern WebAuthn process.
Comment 4 Jiewen Tan 2020-10-29 13:24:22 PDT 
Comment on attachment 412069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412069&action=review

Thanks Brent for r+ this patch.

>> Source/WebKit/Scripts/process-entitlements.sh:317
>> +#    elif [[ "${PRODUCT_NAME}" == com.apple.WebKit.WebAuthn ]]; then ios_family_process_webauthn_entitlements
> 
> Did you mean to have this commented out?
> 
> If so, please include a # FIXME() comment with the bug number to enable it.

Just forgot to uncomment it... Good catch!

>> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:168
>> +    // If so, continue to the old route. Otherwise, use the modern WebAuthn process way.
> 
> I suggest a FIXME bug here to remove this code once we cut-over to the modern WebAuthn process.

Fixed. rdar://problem/70822834
Comment 5 Jiewen Tan 2020-10-29 13:27:47 PDT 
Created attachment 412679 [details]
Patch for landing
Comment 6 EWS 2020-10-29 14:10:15 PDT 
Committed r269168: <https://trac.webkit.org/changeset/269168>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412679 [details].