Bug 218064 – Web Inspector: REGRESSION(r266074): Sources: icon for non-JavaScript breakpoints doesn't change when breakpoints are globally disabled

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

# STEPS TO REPRODUCE
1. inspect any page
2. add any non-JavaScript breakpoint (e.g. All Listeners)
3. disable breakpoints globally

# EXPECTED
icon next to the breakpoint added in step 2 should go greyscale

# ACTUAL
icon next to the breakpoint added in step 2 is still colored

[Devin Rousso]

my guess is that this was caused by r266074

[Devin Rousso]

Created attachment 412055 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 412055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412055&action=review

r=me

> Source/WebInspectorUI/ChangeLog:12
> +        Add `get resolved` to the base class based on `WI.debuggerManager.breakpointsEnabled`. Use

What causes the entire sidebar to update status when the global state changes?

[Devin Rousso]

Comment on attachment 412055 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412055&action=review

>> Source/WebInspectorUI/ChangeLog:12
>> +        Add `get resolved` to the base class based on `WI.debuggerManager.breakpointsEnabled`. Use
> 
> What causes the entire sidebar to update status when the global state changes?

Each `WI.BreakpointTreeElement` adds a listener for `WI.DebuggerManager.Event.BreakpointsEnabledDidChange`, which uses `get resolved` in the handler `updateStatus`.

`WI.SourcesNavigationSidebarPanel` also has it's own listener for `WI.DebuggerManager.Event.BreakpointsEnabledDidChange` that updates the button and the "breakpoints disabled" banner at the top, but that's separate.

[EWS]

Committed r268885: <https://trac.webkit.org/changeset/268885>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412055 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70586182>