Bug 218060 - [LFC][IFC] Handle line box sizing quirks at the line box level
Summary: [LFC][IFC] Handle line box sizing quirks at the line box level
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
: 217941 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-10-21 16:45 PDT by zalan
Modified: 2020-10-22 07:45 PDT (History)
5 users (show)

See Also:


Attachments
Patch (14.21 KB, patch)
2020-10-21 17:29 PDT, zalan
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (14.65 KB, patch)
2020-10-21 19:01 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (14.50 KB, patch)
2020-10-22 06:17 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (14.53 KB, patch)
2020-10-22 06:21 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-10-21 16:45:16 PDT
and not by stretching the inline level boxes
Comment 1 zalan 2020-10-21 17:29:44 PDT
Created attachment 412053 [details]
Patch
Comment 2 zalan 2020-10-21 19:01:18 PDT
*** Bug 217941 has been marked as a duplicate of this bug. ***
Comment 3 zalan 2020-10-21 19:01:50 PDT
Created attachment 412058 [details]
Patch
Comment 4 Antti Koivisto 2020-10-22 06:09:16 PDT
Comment on attachment 412058 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412058&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:359
> +            if (inlineLevelBox.isEmpty())
> +                return false;
> +            return quirks.shouldInlineLevelBoxStretchLineBox(lineBox, inlineLevelBox);

maybe the inlineLevelBox.isEmpty() test could go to the quirk too so the lambda would go away?
Comment 5 zalan 2020-10-22 06:17:46 PDT
Created attachment 412088 [details]
Patch
Comment 6 zalan 2020-10-22 06:21:06 PDT
Created attachment 412090 [details]
Patch
Comment 7 EWS 2020-10-22 07:44:03 PDT
Committed r268864: <https://trac.webkit.org/changeset/268864>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412090 [details].
Comment 8 Radar WebKit Bug Importer 2020-10-22 07:45:31 PDT
<rdar://problem/70573591>