Bug 218058 – Web Inspector: Network: background color of rows from previous session is wrong

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

# STEPS TO REPRODUCE
1. inspect any page
2. enable the Preserve Log checkbox in the Network Tab
3. reload the page (might have to do this a few times)

# EXPECTED
rows from previous sessions have the same odd-even-odd-... background coloring

# ACTUAL
rows from previous sessions are made more transparent, causing even rows from previous sessions to have an extremely similar background color to odd rows from the current session

[Radar WebKit Bug Importer]

<rdar://problem/70550459>

[Federico Bucchi]

Created attachment 412509 [details]
Web Inspector: Network: Fix background color of rows from previous session

[Devin Rousso]

Comment on attachment 412509 [details]
Web Inspector: Network: Fix background color of rows from previous session

View in context: https://bugs.webkit.org/attachment.cgi?id=412509&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css:53
> +.network-table > .table li:not(.filler, .selected) .cell:not(.current-session):not(.name) {

`:not(.name, .current-session)`?

> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css:61
> +.network-table > .table li:not(.filler) .cell.name:not(.current-session) > * {

What about `.selected`?  I'm actually kinda OK with the idea of still having it be slightly transparent when selected, but probably not this much.
```
    .network-table > .table li:not(.filler).selected .cell.name:not(.current-session) > * {
        opacity: 0.8;
    }
```

[Federico Bucchi]

Created attachment 412571 [details]
Web Inspector: Network: Fix background color of rows from previous session

[Devin Rousso]

Comment on attachment 412571 [details]
Web Inspector: Network: Fix background color of rows from previous session

r=me

[EWS]

Committed r269127: <https://trac.webkit.org/changeset/269127>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412571 [details].