Bug 218058 - Web Inspector: Network: background color of rows from previous session is wrong
Summary: Web Inspector: Network: background color of rows from previous session is wrong
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-21 16:26 PDT by Devin Rousso
Modified: 2020-10-28 14:34 PDT (History)
4 users (show)

See Also:


Attachments
Web Inspector: Network: Fix background color of rows from previous session (1.93 KB, patch)
2020-10-27 23:35 PDT, Federico Bucchi
no flags Details | Formatted Diff | Diff
Web Inspector: Network: Fix background color of rows from previous session (1.67 KB, patch)
2020-10-28 13:55 PDT, Federico Bucchi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-10-21 16:26:27 PDT
# STEPS TO REPRODUCE
1. inspect any page
2. enable the Preserve Log checkbox in the Network Tab
3. reload the page (might have to do this a few times)

# EXPECTED
rows from previous sessions have the same odd-even-odd-... background coloring

# ACTUAL
rows from previous sessions are made more transparent, causing even rows from previous sessions to have an extremely similar background color to odd rows from the current session
Comment 1 Radar WebKit Bug Importer 2020-10-21 16:27:03 PDT
<rdar://problem/70550459>
Comment 2 Federico Bucchi 2020-10-27 23:35:56 PDT
Created attachment 412509 [details]
Web Inspector: Network: Fix background color of rows from previous session
Comment 3 Devin Rousso 2020-10-28 10:49:37 PDT
Comment on attachment 412509 [details]
Web Inspector: Network: Fix background color of rows from previous session

View in context: https://bugs.webkit.org/attachment.cgi?id=412509&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css:53
> +.network-table > .table li:not(.filler, .selected) .cell:not(.current-session):not(.name) {

`:not(.name, .current-session)`?

> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css:61
> +.network-table > .table li:not(.filler) .cell.name:not(.current-session) > * {

What about `.selected`?  I'm actually kinda OK with the idea of still having it be slightly transparent when selected, but probably not this much.
```
    .network-table > .table li:not(.filler).selected .cell.name:not(.current-session) > * {
        opacity: 0.8;
    }
```
Comment 4 Federico Bucchi 2020-10-28 13:55:29 PDT
Created attachment 412571 [details]
Web Inspector: Network: Fix background color of rows from previous session
Comment 5 Devin Rousso 2020-10-28 14:06:07 PDT
Comment on attachment 412571 [details]
Web Inspector: Network: Fix background color of rows from previous session

r=me
Comment 6 EWS 2020-10-28 14:34:09 PDT
Committed r269127: <https://trac.webkit.org/changeset/269127>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412571 [details].