In preparation for blocking Launch Services in the WebContent process' sandbox, application information for the process should be set in the Networking process.
Created attachment 412044 [details] Patch
Created attachment 412046 [details] Patch
Created attachment 412048 [details] Patch
Created attachment 412105 [details] Patch
<rdar://problem/70586405>
Created attachment 413311 [details] Patch
Created attachment 413317 [details] Patch
Comment on attachment 413317 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=413317&action=review r=me > Source/WTF/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=218052 <rdar://problem/70586405> > Source/WebCore/PAL/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=218052 <rdar://problem/70586405> > Source/WebKit/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=218052 rdar://problem/70586405 > Source/WebKit/NetworkProcess/mac/NetworkConnectionToWebProcessMac.mm:38 > + if (!overrideDisplayName) Do we override if 'overrideDisplayName' is an empty string? I think this code will use a blank string for the name -- is that what we want? > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:687 > + WTFLogAlways("Unable to get audit token for self."); Shouldn't we show the error # in this log message?
Created attachment 413623 [details] Patch
(In reply to Brent Fulgham from comment #8) > Comment on attachment 413317 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=413317&action=review > > r=me > > > Source/WTF/ChangeLog:4 > > + https://bugs.webkit.org/show_bug.cgi?id=218052 > > <rdar://problem/70586405> > > > Source/WebCore/PAL/ChangeLog:4 > > + https://bugs.webkit.org/show_bug.cgi?id=218052 > > <rdar://problem/70586405> > > > Source/WebKit/ChangeLog:4 > > + https://bugs.webkit.org/show_bug.cgi?id=218052 > > rdar://problem/70586405 > > > Source/WebKit/NetworkProcess/mac/NetworkConnectionToWebProcessMac.mm:38 > > + if (!overrideDisplayName) > > Do we override if 'overrideDisplayName' is an empty string? I think this > code will use a blank string for the name -- is that what we want? > Yes, you're right, that is a good point. I am not quite sure what the expected behavior here is. This patch should not change the current behavior, I believe. > > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:687 > > + WTFLogAlways("Unable to get audit token for self."); > > Shouldn't we show the error # in this log message? Fixed. Thanks for reviewing!
Created attachment 414977 [details] Patch
Committed r270219: <https://trac.webkit.org/changeset/270219> All reviewed patches have been landed. Closing bug and clearing flags on attachment 414977 [details].