Bug 218043 – [LFC][IFC] Apply font line-spacing to <br> inline level box

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

ssia

[zalan]

Created attachment 412014 [details]
Patch

[Antti Koivisto]

Comment on attachment 412014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412014&action=review

> Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:183
> +        auto lineSpacing = isRootInlineBox(inlineLevelBox) || inlineLevelBox.isLineBreakBox() ? fontMetrics.lineSpacing() - logicalHeight : InlineLayoutUnit();

I usually put parenthesis around this sort of things `(a || b) ? :` since it can be difficult to parse otherwise (or just put the condition to a temporary).

[zalan]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 412014 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=412014&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:183
> > +        auto lineSpacing = isRootInlineBox(inlineLevelBox) || inlineLevelBox.isLineBreakBox() ? fontMetrics.lineSpacing() - logicalHeight : InlineLayoutUnit();
> 
> I usually put parenthesis around this sort of things `(a || b) ? :` since it
> can be difficult to parse otherwise (or just put the condition to a
> temporary).
good point. will fix.

[zalan]

Created attachment 412021 [details]
Patch

[EWS]

Committed r268823: <https://trac.webkit.org/changeset/268823>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412021 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70545083>