WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
21803
Fuse op_jfalse with op_eq_null and op_neq_null
https://bugs.webkit.org/show_bug.cgi?id=21803
Summary
Fuse op_jfalse with op_eq_null and op_neq_null
Cameron Zwarich (cpst)
Reported
2008-10-22 10:50:27 PDT
Branches of the form if (a == null) ... and if (a != null) ... are common on the V8 Richards benchmark. We should create new opcodes that fuse these instructions.
Attachments
Proposed patch
(9.12 KB, patch)
2008-10-22 13:24 PDT
,
Cameron Zwarich (cpst)
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Cameron Zwarich (cpst)
Comment 1
2008-10-22 13:24:17 PDT
Created
attachment 24568
[details]
Proposed patch
Geoffrey Garen
Comment 2
2008-10-22 13:55:13 PDT
Comment on
attachment 24568
[details]
Proposed patch 3054 /* jneq_null cond(r) target(offset) 3036 /* jeq_null cond(r) target(offset) Let's call "cond" "src", like you suggested. Seems like we might get a little speedup out of experimenting with the asm a little, but this looks good. r=me
Cameron Zwarich (cpst)
Comment 3
2008-10-22 14:07:01 PDT
Landed in
r37789
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug