Bug 21802 - Rename HAVE_ACCESSIBILITY to ENABLE_ACCESSIBILITY
Summary: Rename HAVE_ACCESSIBILITY to ENABLE_ACCESSIBILITY
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-22 10:16 PDT by Sam Weinig
Modified: 2019-07-09 18:07 PDT (History)
7 users (show)

See Also:

Attachments
Patch (72.98 KB, patch)
2018-11-13 20:54 PST, Fujii Hironori 		achristensen: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2008-10-22 10:16:01 PDT 
While the current macros for platforms/features are not entirely clear or fleshed out, it doesn't really make sense for accessibility to be a HAVE.
Comment 1 David Kilzer (:ddkilzer) 2008-11-08 04:41:42 PST 
See Bug 21443 Comment #2 and Bug 21443 Comment #3.
Comment 2 Fujii Hironori 2018-11-13 20:54:41 PST 
Created attachment 354763 [details]
Patch
Comment 3 Fujii Hironori 2018-11-13 20:57:22 PST 
Here is the command I invoked.

> sed -i -e 's/HAVE_ACCESSIBILITY/ENABLE_ACCESSIBILITY/' Source/WTF/wtf/Platform.h
> git ls-files -z Source Tools | egrep -z '\.(h|c|cpp|m|mm)$' | xargs --null grep -lZ 'HAVE(ACCESSIBILITY)' | xargs --null sed -i -e 's/HAVE(ACCESSIBILITY)/ENABLE(ACCESSIBILITY)/'

Then, I checked the remaining HAVE_ACCESSIBILITY and HAVE(ACCESSIBILITY).

> git ls-files -z . | xargs --null grep 'HAVE.ACCESSIBILITY'

I confirmed it shows only ChangeLogs and PerformanceTests.
Comment 4 Fujii Hironori 2018-11-14 16:53:57 PST 
AppleWin EWS failed.

> C:\cygwin\home\buildbot\WebKit\Source\WebCore\accessibility\win\AXObjectCacheWin.cpp(46): error C2084: function 'void WebCore::AXObjectCache::detachWrapper(WebCore::AccessibilityObject *,WebCore::AccessibilityDetachmentType)' already has a body
Comment 5 Fujii Hironori 2018-11-14 17:12:29 PST 
Thank you for the review.
But, I changed my mind. I think I should ask removing HAVE_ACCESSIBILITY in webkit-dev.
Comment 6 Ross Kirsling 2018-11-14 18:21:59 PST 
(In reply to Fujii Hironori from comment #5)
> Thank you for the review.
> But, I changed my mind. I think I should ask removing HAVE_ACCESSIBILITY in
> webkit-dev.

I don't think you need to hesitate -- it seems to be an existing mistake that AXObjectCacheWin.cpp has no #if HAVE(ACCESSIBILITY) wrapper.
Comment 7 Fujii Hironori 2018-11-26 20:23:55 PST 
We decided not to rename. WONTFIX.