Bug 21802 – Rename HAVE_ACCESSIBILITY to ENABLE_ACCESSIBILITY

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Accessibility

[Sam Weinig]

While the current macros for platforms/features are not entirely clear or fleshed out, it doesn't really make sense for accessibility to be a HAVE.

[David Kilzer (:ddkilzer)]

See Bug 21443 Comment #2 and Bug 21443 Comment #3.

[Fujii Hironori]

Created attachment 354763 [details]
Patch

[Fujii Hironori]

Here is the command I invoked.

> sed -i -e 's/HAVE_ACCESSIBILITY/ENABLE_ACCESSIBILITY/' Source/WTF/wtf/Platform.h
> git ls-files -z Source Tools | egrep -z '\.(h|c|cpp|m|mm)$' | xargs --null grep -lZ 'HAVE(ACCESSIBILITY)' | xargs --null sed -i -e 's/HAVE(ACCESSIBILITY)/ENABLE(ACCESSIBILITY)/'

Then, I checked the remaining HAVE_ACCESSIBILITY and HAVE(ACCESSIBILITY).

> git ls-files -z . | xargs --null grep 'HAVE.ACCESSIBILITY'

I confirmed it shows only ChangeLogs and PerformanceTests.

[Fujii Hironori]

AppleWin EWS failed.

> C:\cygwin\home\buildbot\WebKit\Source\WebCore\accessibility\win\AXObjectCacheWin.cpp(46): error C2084: function 'void WebCore::AXObjectCache::detachWrapper(WebCore::AccessibilityObject *,WebCore::AccessibilityDetachmentType)' already has a body

[Fujii Hironori]

Thank you for the review.
But, I changed my mind. I think I should ask removing HAVE_ACCESSIBILITY in webkit-dev.

[Ross Kirsling]

(In reply to Fujii Hironori from comment #5)
> Thank you for the review.
> But, I changed my mind. I think I should ask removing HAVE_ACCESSIBILITY in
> webkit-dev.

I don't think you need to hesitate -- it seems to be an existing mistake that AXObjectCacheWin.cpp has no #if HAVE(ACCESSIBILITY) wrapper.

[Fujii Hironori]

We decided not to rename. WONTFIX.