Bug 218019 - Introduce worklet destinations and allow to fetch modules with CORS based on destination
Summary: Introduce worklet destinations and allow to fetch modules with CORS based on ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-21 05:53 PDT by youenn fablet
Modified: 2020-10-22 11:06 PDT (History)
14 users (show)

See Also:


Attachments
Patch (13.94 KB, patch)
2020-10-22 05:01 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (13.93 KB, patch)
2020-10-22 09:26 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-10-21 05:53:05 PDT
Introduce worklet destinations and allow to fetch modules with CORS based on destination
Comment 1 Radar WebKit Bug Importer 2020-10-21 05:53:27 PDT
<rdar://problem/70526201>
Comment 2 youenn fablet 2020-10-22 05:01:27 PDT
Created attachment 412086 [details]
Patch
Comment 3 youenn fablet 2020-10-22 06:33:53 PDT
We might want to further relax the rules for workers but this should be done as a follow-up patch
Comment 4 Chris Dumez 2020-10-22 08:41:20 PDT
Comment on attachment 412086 [details]
Patch

r=me, thanks for fixing.
Comment 5 Chris Dumez 2020-10-22 08:42:12 PDT
Comment on attachment 412086 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412086&action=review

> LayoutTests/http/wpt/webaudio/resources/dummy-worklet.py:16
> +    return true;

Presumably you can return false here since you don't do processing and only care about the module fetching.
Comment 6 youenn fablet 2020-10-22 09:26:05 PDT
Created attachment 412107 [details]
Patch for landing
Comment 7 EWS 2020-10-22 11:06:52 PDT
Committed r268872: <https://trac.webkit.org/changeset/268872>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412107 [details].