Bug 218017 - [LFC][Integration] Update style of contained layout boxes
Summary: [LFC][Integration] Update style of contained layout boxes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-21 05:45 PDT by Antti Koivisto
Modified: 2020-10-21 18:15 PDT (History)
12 users (show)

See Also:

Attachments
patch (19.57 KB, patch)
2020-10-21 05:50 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
for bots (19.76 KB, patch)
2020-10-21 07:02 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (29.65 KB, patch)
2020-10-21 07:59 PDT, Antti Koivisto 		zalan: review+
Details | Formatted Diff | Diff
patch (29.64 KB, patch)
2020-10-21 08:30 PDT, Antti Koivisto 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
followup (1.43 KB, patch)
2020-10-21 12:01 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2020-10-21 05:45:58 PDT 
Need to integrate style updates.
Comment 1 Antti Koivisto 2020-10-21 05:50:25 PDT 
Created attachment 411976 [details]
patch
Comment 2 Antti Koivisto 2020-10-21 07:02:33 PDT 
Created attachment 411981 [details]
for bots
Comment 3 Antti Koivisto 2020-10-21 07:59:28 PDT 
Created attachment 411984 [details]
patch
Comment 4 zalan 2020-10-21 08:28:05 PDT 
Comment on attachment 411984 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411984&action=review

> Source/WebCore/layout/integration/LayoutIntegrationBoxTree.h:71
> +    mutable HashMap<const RenderObject*, Layout::Box*> m_rendererToBoxMap;
> +    mutable HashMap<const Layout::Box*, RenderObject*> m_boxToRendererMap;

probably not need to be mutable anymore, as discussed in slack.
Comment 5 Antti Koivisto 2020-10-21 08:30:33 PDT 
Created attachment 411988 [details]
patch
Comment 6 EWS 2020-10-21 09:21:09 PDT 
Committed r268798: <https://trac.webkit.org/changeset/268798>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411988 [details].
Comment 7 Radar WebKit Bug Importer 2020-10-21 09:22:21 PDT 
<rdar://problem/70531938>
Comment 8 Antti Koivisto 2020-10-21 11:58:48 PDT 
Followup
Comment 9 Antti Koivisto 2020-10-21 12:01:29 PDT 
Created attachment 412013 [details]
followup
Comment 10 EWS 2020-10-21 12:34:09 PDT 
Committed r268818: <https://trac.webkit.org/changeset/268818>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412013 [details].
Comment 11 Carlos Alberto Lopez Perez 2020-10-21 18:12:57 PDT 
Committed r268850: <https://trac.webkit.org/changeset/268850>
Comment 12 Carlos Alberto Lopez Perez 2020-10-21 18:15:45 PDT 
The GTK stable builders build without experimental features enabled and LFC is only enabled when experimental features are enabled, thus it broke those builders. Example: https://build.webkit.org/builders/GTK-Linux-64-bit-Release-Debian-Stable-Build/builds/38728/steps/compile-webkit/logs/stdio

So I landed the build-fix below for !ENABLE_LAYOUT_FORMATTING_CONTEXT

(In reply to Carlos Alberto Lopez Perez from comment #11)
> Committed r268850: <https://trac.webkit.org/changeset/268850>