Bug 217987 - REGRESSION (r268483): Map jumps around while zooming on windy.com, strava.com
Summary: REGRESSION (r268483): Map jumps around while zooming on windy.com, strava.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-20 14:11 PDT by Antoine Quint
Modified: 2020-10-20 17:45 PDT (History)
3 users (show)

See Also:

Attachments
Test (388 bytes, text/html)
2020-10-20 14:13 PDT, Antoine Quint 		no flags Details
Patch (9.22 KB, patch)
2020-10-20 14:38 PDT, Antoine Quint 		simon.fraser: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2020-10-20 14:11:20 PDT 
Load windy.com, and zoom the map in and out with up/down scroll gestures on the trackpad. The map jumps around, seemingly using the wrong zoom origin.
Comment 1 Antoine Quint 2020-10-20 14:11:42 PDT 
<rdar://problem/70418548>
Comment 2 Antoine Quint 2020-10-20 14:13:17 PDT 
Created attachment 411914 [details]
Test

The issue is that when several animations for the same property targeting the same layer are added at the same time, we used to always override the previous animations and now, for transform animations, we actually use additivity over the previous animations.
Comment 3 Antoine Quint 2020-10-20 14:38:47 PDT 
Created attachment 411917 [details]
Patch
Comment 4 Simon Fraser (smfr) 2020-10-20 14:41:21 PDT 
Comment on attachment 411917 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411917&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2960
> +            // animations created for a single KeyframeEffect, one for each trasnform component. In that

trasnform
Comment 5 Antoine Quint 2020-10-20 15:58:56 PDT 
Committed r268771: <https://trac.webkit.org/changeset/268771>