Bug 217985 - [webkitpy] Use allowlist and blocklist
Summary: [webkitpy] Use allowlist and blocklist
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-20 13:34 PDT by Jonathan Bedard
Modified: 2020-10-30 13:32 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.64 KB, patch)
2020-10-20 13:44 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch (3.59 KB, patch)
2020-10-30 13:03 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-10-20 13:34:38 PDT
We should replace blacklist with blocklist and whitelist with allowlist in webkitpy.
Comment 1 Radar WebKit Bug Importer 2020-10-20 13:34:58 PDT
<rdar://problem/70499499>
Comment 2 Jonathan Bedard 2020-10-20 13:44:43 PDT
Created attachment 411912 [details]
Patch
Comment 3 EWS 2020-10-20 14:40:45 PDT
Committed r268761: <https://trac.webkit.org/changeset/268761>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411912 [details].
Comment 4 Truitt Savell 2020-10-23 13:13:43 PDT
Reverted r268761 for reason:

May have casued webrtc crashes on Catalina Debug.

Committed r268938: <https://trac.webkit.org/changeset/268938>
Comment 5 Jonathan Bedard 2020-10-23 13:20:05 PDT
(In reply to Truitt Savell from comment #4)
> Reverted r268761 for reason:
> 
> May have casued webrtc crashes on Catalina Debug.
> 
> Committed r268938: <https://trac.webkit.org/changeset/268938>

Seems super unlikely this is the culprit, but it's also not particularly harmful to revert.
Comment 6 Jonathan Bedard 2020-10-30 13:03:58 PDT
Created attachment 412789 [details]
Patch
Comment 7 EWS 2020-10-30 13:32:13 PDT
Committed r269205: <https://trac.webkit.org/changeset/269205>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 412789 [details].