Bug 217984 - [macOS WK1] provide a way for Apple-internal clients to disable link preview
Summary: [macOS WK1] provide a way for Apple-internal clients to disable link preview
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-20 13:33 PDT by Devin Rousso
Modified: 2020-10-21 11:43 PDT (History)
10 users (show)

See Also:


Attachments
Patch (4.97 KB, patch)
2020-10-20 14:03 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (4.98 KB, patch)
2020-10-20 14:40 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-10-20 13:33:59 PDT
this should (roughly) match the public `@property BOOL allowsLinkPreview` API on `WKWebView`
Comment 1 Devin Rousso 2020-10-20 13:34:12 PDT
<rdar://problem/42033485>
Comment 2 Devin Rousso 2020-10-20 13:52:15 PDT
<rdar://problem/70500022>
Comment 3 Devin Rousso 2020-10-20 14:03:30 PDT
Created attachment 411913 [details]
Patch
Comment 4 Tim Horton 2020-10-20 14:08:19 PDT
Comment on attachment 411913 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411913&action=review

> Source/WebKitLegacy/mac/WebView/WebImmediateActionController.h:61
> +@property (nonatomic) BOOL enabled;

getter=isEnabled?
Comment 5 Devin Rousso 2020-10-20 14:40:03 PDT
Created attachment 411918 [details]
Patch
Comment 6 EWS 2020-10-21 11:43:38 PDT
Committed r268813: <https://trac.webkit.org/changeset/268813>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411918 [details].