Bug 217978 – [WebGPU] Increase portability of GPUBindGroup

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

[Don Olmstead]

Remove more USE(METAL)

[Don Olmstead]

Created attachment 411897 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 411897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411897&action=review

> Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupAllocatorMetal.mm:-167
> -#endif // USE(METAL)

This doesn't seem right. The file name ends in Metal and it's in a Cocoa folder. Presumably, if code needs to be shared, it should be moved to a more central place.

[Don Olmstead]

Comment on attachment 411897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411897&action=review

>> Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupAllocatorMetal.mm:-167
>> -#endif // USE(METAL)
> 
> This doesn't seem right. The file name ends in Metal and it's in a Cocoa folder. Presumably, if code needs to be shared, it should be moved to a more central place.

This is just moving the #endif to correspond to where it is in corresponding header. Those methods used to correspond to a USE(METAL) guard but now don't.

I agree with you that the gpu/cocoa directory should be gpu/metal and any instances of USE(METAL) or PLATFORM(COCOA) should be removed from files contained there. I opened https://bugs.webkit.org/show_bug.cgi?id=217981 for that work.

[Myles C. Maxfield]

(In reply to Don Olmstead from comment #3)
> Comment on attachment 411897 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411897&action=review
> 
> >> Source/WebCore/platform/graphics/gpu/cocoa/GPUBindGroupAllocatorMetal.mm:-167
> >> -#endif // USE(METAL)
> > 
> > This doesn't seem right. The file name ends in Metal and it's in a Cocoa folder. Presumably, if code needs to be shared, it should be moved to a more central place.
> 
> This is just moving the #endif to correspond to where it is in corresponding
> header. Those methods used to correspond to a USE(METAL) guard but now don't.
> 
> I agree with you that the gpu/cocoa directory should be gpu/metal and any
> instances of USE(METAL) or PLATFORM(COCOA) should be removed from files
> contained there. I opened https://bugs.webkit.org/show_bug.cgi?id=217981 for
> that work.

I followed up with Don offline. The movement of the #endif wasn't to make that port build; it was just to match what was in the .h file for symmetry.

[EWS]

Committed r268766: <https://trac.webkit.org/changeset/268766>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411897 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70504009>