.
Created attachment 411888 [details] Patch
unofficial lgtm :)
Comment on attachment 411888 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411888&action=review > Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:320 > - gst_element_register(0, "webkitglvideosink", GST_RANK_PRIMARY, WEBKIT_TYPE_GL_VIDEO_SINK); > + gst_element_register(0, "webkitglvideosink", GST_RANK_NONE, WEBKIT_TYPE_GL_VIDEO_SINK); Why do you need this? > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2732 > + GST_INFO("Creating pipeline for %s player", m_player->isVideoPlayer() ? "video":"audio"); Nit: spaces around :
Comment on attachment 411888 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411888&action=review >> Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:320 >> + gst_element_register(0, "webkitglvideosink", GST_RANK_NONE, WEBKIT_TYPE_GL_VIDEO_SINK); > > Why do you need this? Because if we don't give a video-sink to playbin it will create an autovideosink, which, without this change, would create a webkitglvideosink.
Committed r268790: <https://trac.webkit.org/changeset/268790>
<rdar://problem/70523722>