Bug 217974 - [GStreamer] Create video sink only for video player
Summary: [GStreamer] Create video sink only for video player
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-20 10:53 PDT by Philippe Normand
Modified: 2020-10-21 03:52 PDT (History)
12 users (show)

See Also:


Attachments
Patch (3.63 KB, patch)
2020-10-20 10:58 PDT, Philippe Normand
calvaris: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2020-10-20 10:53:36 PDT
.
Comment 1 Philippe Normand 2020-10-20 10:58:07 PDT
Created attachment 411888 [details]
Patch
Comment 2 Víctor M. Jáquez L. 2020-10-21 02:36:23 PDT
unofficial lgtm :)
Comment 3 Xabier Rodríguez Calvar 2020-10-21 02:48:06 PDT
Comment on attachment 411888 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411888&action=review

> Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:320
> -        gst_element_register(0, "webkitglvideosink", GST_RANK_PRIMARY, WEBKIT_TYPE_GL_VIDEO_SINK);
> +        gst_element_register(0, "webkitglvideosink", GST_RANK_NONE, WEBKIT_TYPE_GL_VIDEO_SINK);

Why do you need this?

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2732
> +    GST_INFO("Creating pipeline for %s player", m_player->isVideoPlayer() ? "video":"audio");

Nit: spaces around :
Comment 4 Philippe Normand 2020-10-21 03:11:29 PDT
Comment on attachment 411888 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411888&action=review

>> Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:320
>> +        gst_element_register(0, "webkitglvideosink", GST_RANK_NONE, WEBKIT_TYPE_GL_VIDEO_SINK);
> 
> Why do you need this?

Because if we don't give a video-sink to playbin it will create an autovideosink, which, without this change, would create a webkitglvideosink.
Comment 5 Philippe Normand 2020-10-21 03:51:08 PDT
Committed r268790: <https://trac.webkit.org/changeset/268790>
Comment 6 Radar WebKit Bug Importer 2020-10-21 03:52:21 PDT
<rdar://problem/70523722>