WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
217942
[JSC] Rename item() to at() and move it behind a flag
https://bugs.webkit.org/show_bug.cgi?id=217942
Summary
[JSC] Rename item() to at() and move it behind a flag
Ross Kirsling
Reported
2020-10-19 21:32:26 PDT
[JSC] Rename item() to at() and move it behind a flag
Attachments
Patch
(19.68 KB, patch)
2020-10-19 21:40 PDT
,
Ross Kirsling
no flags
Details
Formatted Diff
Diff
Patch
(20.32 KB, patch)
2020-10-19 22:51 PDT
,
Ross Kirsling
no flags
Details
Formatted Diff
Diff
Patch
(22.69 KB, patch)
2020-10-19 23:45 PDT
,
Ross Kirsling
no flags
Details
Formatted Diff
Diff
Patch
(22.14 KB, patch)
2020-10-20 11:46 PDT
,
Ross Kirsling
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Ross Kirsling
Comment 1
2020-10-19 21:40:26 PDT
Created
attachment 411837
[details]
Patch
Ross Kirsling
Comment 2
2020-10-19 22:46:41 PDT
Comment hidden (obsolete)
Comment on
attachment 411837
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=411837&action=review
> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:126 > const Identifier* const unscopableNames[] = { > + &vm.propertyNames->builtinNames().atPublicName(), > &vm.propertyNames->builtinNames().copyWithinPublicName(),
Hmm, I'm not exactly sure how I should guard this...
Ross Kirsling
Comment 3
2020-10-19 22:51:40 PDT
Created
attachment 411838
[details]
Patch
Ross Kirsling
Comment 4
2020-10-19 23:45:31 PDT
Created
attachment 411842
[details]
Patch
Ross Kirsling
Comment 5
2020-10-20 11:46:54 PDT
Created
attachment 411894
[details]
Patch
Yusuke Suzuki
Comment 6
2020-10-20 11:52:57 PDT
Comment on
attachment 411894
[details]
Patch r=me
EWS
Comment 7
2020-10-20 14:23:58 PDT
Committed
r268760
: <
https://trac.webkit.org/changeset/268760
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 411894
[details]
.
Radar WebKit Bug Importer
Comment 8
2020-10-20 14:24:17 PDT
<
rdar://problem/70501632
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug