217942 – [JSC] Rename item() to at() and move it behind a flag

Bug 217942 - [JSC] Rename item() to at() and move it behind a flag

Summary: [JSC] Rename item() to at() and move it behind a flag

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Ross Kirsling

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2020-10-19 21:32 PDT by Ross Kirsling
Modified:	2020-10-20 14:24 PDT (History)
CC List:	10 users (show)

See Also:

Attachments
Patch (19.68 KB, patch) 2020-10-19 21:40 PDT, Ross Kirsling	no flags	Details \| Formatted Diff \| Diff
Patch (20.32 KB, patch) 2020-10-19 22:51 PDT, Ross Kirsling	no flags	Details \| Formatted Diff \| Diff
Patch (22.69 KB, patch) 2020-10-19 23:45 PDT, Ross Kirsling	no flags	Details \| Formatted Diff \| Diff
Patch (22.14 KB, patch) 2020-10-20 11:46 PDT, Ross Kirsling	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ross Kirsling 2020-10-19 21:32:26 PDT

[JSC] Rename item() to at() and move it behind a flag

Comment 1 Ross Kirsling 2020-10-19 21:40:26 PDT

Created attachment 411837 [details]
Patch

Comment 2 Ross Kirsling 2020-10-19 22:46:41 PDT Comment hidden (obsolete)

Comment on attachment 411837 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411837&action=review

> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:126
>      const Identifier* const unscopableNames[] = {
> +        &vm.propertyNames->builtinNames().atPublicName(),
>          &vm.propertyNames->builtinNames().copyWithinPublicName(),

Hmm, I'm not exactly sure how I should guard this...

Comment 3 Ross Kirsling 2020-10-19 22:51:40 PDT

Created attachment 411838 [details]
Patch

Comment 4 Ross Kirsling 2020-10-19 23:45:31 PDT

Created attachment 411842 [details]
Patch

Comment 5 Ross Kirsling 2020-10-20 11:46:54 PDT

Created attachment 411894 [details]
Patch

Comment 6 Yusuke Suzuki 2020-10-20 11:52:57 PDT

Comment on attachment 411894 [details]
Patch

r=me

Comment 7 EWS 2020-10-20 14:23:58 PDT

Committed r268760: <https://trac.webkit.org/changeset/268760>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411894 [details].

Comment 8 Radar WebKit Bug Importer 2020-10-20 14:24:17 PDT

<rdar://problem/70501632>