Bug 217942 – [JSC] Rename item() to at() and move it behind a flag

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ross Kirsling]

[JSC] Rename item() to at() and move it behind a flag

[Ross Kirsling]

Created attachment 411837 [details]
Patch

[Ross Kirsling]

Comment on attachment 411837 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411837&action=review

> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:126
>      const Identifier* const unscopableNames[] = {
> +        &vm.propertyNames->builtinNames().atPublicName(),
>          &vm.propertyNames->builtinNames().copyWithinPublicName(),

Hmm, I'm not exactly sure how I should guard this...

[Ross Kirsling]

Created attachment 411838 [details]
Patch

[Ross Kirsling]

Created attachment 411842 [details]
Patch

[Ross Kirsling]

Created attachment 411894 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 411894 [details]
Patch

r=me

[EWS]

Committed r268760: <https://trac.webkit.org/changeset/268760>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411894 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70501632>