WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
217927
Remove iOS-only NSUserDefaults-backed UA override
https://bugs.webkit.org/show_bug.cgi?id=217927
Summary
Remove iOS-only NSUserDefaults-backed UA override
Tim Horton
Reported
2020-10-19 16:00:23 PDT
We should remove the code in UserAgentIOS.mm that reads an override UA from the NSUserDefault [com.apple.WebFoundation UserAgent]. It is incompatible with the modern need to compose the UA from various bits of information these days (e.g. desktop vs. mobile). Clients should use the API to set the application name or UA instead. I have stumbled upon one client (com.fark.hey), and there are likely others, so it should be a linked-on-or-after change.
Attachments
Add attachment
proposed patch, testcase, etc.
Tim Horton
Comment 1
2020-10-19 16:04:40 PDT
I left a reference here next to the code in
https://trac.webkit.org/changeset/268697/webkit
Radar WebKit Bug Importer
Comment 2
2020-10-26 16:01:21 PDT
<
rdar://problem/70699433
>
Ahmad Saleem
Comment 3
2022-09-12 14:37:01 PDT
Just to update that this FIXME is still present:
https://github.com/WebKit/WebKit/blob/6ead5274db5f92656360fa1fbae3e0091481fc4f/Source/WebCore/platform/ios/UserAgentIOS.mm#L90
Abrar Rahman Protyasha
Comment 4
2023-06-09 00:24:06 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/14805
EWS
Comment 5
2023-06-09 14:05:15 PDT
Committed
265034@main
(6a68b0c65d6c): <
https://commits.webkit.org/265034@main
> Reviewed commits have been landed. Closing PR #14805 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug