Bug 217927 - Remove iOS-only NSUserDefaults-backed UA override
Summary: Remove iOS-only NSUserDefaults-backed UA override
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-19 16:00 PDT by Tim Horton
Modified: 2023-06-09 14:05 PDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2020-10-19 16:00:23 PDT 
We should remove the code in UserAgentIOS.mm that reads an override UA from the NSUserDefault [com.apple.WebFoundation UserAgent].

It is incompatible with the modern need to compose the UA from various bits of information these days (e.g. desktop vs. mobile). Clients should use the API to set the application name or UA instead.

I have stumbled upon one client (com.fark.hey), and there are likely others, so it should be a linked-on-or-after change.
Comment 1 Tim Horton 2020-10-19 16:04:40 PDT 
I left a reference here next to the code in https://trac.webkit.org/changeset/268697/webkit
Comment 2 Radar WebKit Bug Importer 2020-10-26 16:01:21 PDT 
<rdar://problem/70699433>
Comment 4 Abrar Rahman Protyasha 2023-06-09 00:24:06 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/14805
Comment 5 EWS 2023-06-09 14:05:15 PDT 
Committed 265034@main (6a68b0c65d6c): <https://commits.webkit.org/265034@main>

Reviewed commits have been landed. Closing PR #14805 and removing active labels.