S3 access tokens may expire, we need to refresh the S3 context when we detect that the authentication provider has changed the access token.
<rdar://problem/70387457>
Created attachment 411806 [details] Patch
Comment on attachment 411806 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411806&action=review > Tools/Scripts/libraries/resultsdbpy/resultsdbpy/model/s3_archiver.py:92 > + if self._cached_token != self.credentials.aws_session_token: Maybe adding a null check here or assert on constructor to make sure self.credentials is not None?
Comment on attachment 411806 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411806&action=review >> Tools/Scripts/libraries/resultsdbpy/resultsdbpy/model/s3_archiver.py:92 >> + if self._cached_token != self.credentials.aws_session_token: > > Maybe adding a null check here or assert on constructor to make sure self.credentials is not None? I can put this check in the __init__, because (although the review hides it), line 63 will raise an exception first.
Created attachment 411811 [details] Patch
Comment on attachment 411806 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411806&action=review >>> Tools/Scripts/libraries/resultsdbpy/resultsdbpy/model/s3_archiver.py:92 >>> + if self._cached_token != self.credentials.aws_session_token: >> >> Maybe adding a null check here or assert on constructor to make sure self.credentials is not None? > > I can put this check in the __init__, because (although the review hides it), line 63 will raise an exception first. Got it.
r=me
Committed r268702: <https://trac.webkit.org/changeset/268702> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411811 [details].