WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
217924
[results.webkit.org] Refresh S3 context when token expires
https://bugs.webkit.org/show_bug.cgi?id=217924
Summary
[results.webkit.org] Refresh S3 context when token expires
Jonathan Bedard
Reported
2020-10-19 15:22:37 PDT
S3 access tokens may expire, we need to refresh the S3 context when we detect that the authentication provider has changed the access token.
Attachments
Patch
(2.10 KB, patch)
2020-10-19 15:30 PDT
,
Jonathan Bedard
dewei_zhu: review+
Details
Formatted Diff
Diff
Patch
(2.20 KB, patch)
2020-10-19 16:33 PDT
,
Jonathan Bedard
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Jonathan Bedard
Comment 1
2020-10-19 15:23:11 PDT
<
rdar://problem/70387457
>
Jonathan Bedard
Comment 2
2020-10-19 15:30:17 PDT
Created
attachment 411806
[details]
Patch
dewei_zhu
Comment 3
2020-10-19 15:41:34 PDT
Comment on
attachment 411806
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=411806&action=review
> Tools/Scripts/libraries/resultsdbpy/resultsdbpy/model/s3_archiver.py:92 > + if self._cached_token != self.credentials.aws_session_token:
Maybe adding a null check here or assert on constructor to make sure self.credentials is not None?
Jonathan Bedard
Comment 4
2020-10-19 15:52:28 PDT
Comment on
attachment 411806
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=411806&action=review
>> Tools/Scripts/libraries/resultsdbpy/resultsdbpy/model/s3_archiver.py:92 >> + if self._cached_token != self.credentials.aws_session_token: > > Maybe adding a null check here or assert on constructor to make sure self.credentials is not None?
I can put this check in the __init__, because (although the review hides it), line 63 will raise an exception first.
Jonathan Bedard
Comment 5
2020-10-19 16:33:32 PDT
Created
attachment 411811
[details]
Patch
dewei_zhu
Comment 6
2020-10-19 16:42:27 PDT
Comment on
attachment 411806
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=411806&action=review
>>> Tools/Scripts/libraries/resultsdbpy/resultsdbpy/model/s3_archiver.py:92 >>> + if self._cached_token != self.credentials.aws_session_token: >> >> Maybe adding a null check here or assert on constructor to make sure self.credentials is not None? > > I can put this check in the __init__, because (although the review hides it), line 63 will raise an exception first.
Got it.
dewei_zhu
Comment 7
2020-10-19 16:42:56 PDT
r=me
EWS
Comment 8
2020-10-19 17:29:53 PDT
Committed
r268702
: <
https://trac.webkit.org/changeset/268702
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 411811
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug