[MotionMark] Add state change items to represent changes to stroke and fill state

[Wenson Hsieh]

SSIA

[Wenson Hsieh]

Created attachment 411802 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 411802 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411802&action=review

> Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:409
> +    Color m_color;
> +    float m_thickness { 0 };
> +    bool m_hasColor { false };
> +    bool m_hasThickness { false };

Are you doing it this way, rather than Optional<>, for better packing?

[Wenson Hsieh]

(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 411802 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411802&action=review
> 
> > Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:409
> > +    Color m_color;
> > +    float m_thickness { 0 };
> > +    bool m_hasColor { false };
> > +    bool m_hasThickness { false };
> 
> Are you doing it this way, rather than Optional<>, for better packing?

Yep! (as explained in the ChangeLog)

[Wenson Hsieh]

Comment on attachment 411802 [details]
Patch

Thanks for the review!

[EWS]

Committed r268704: <https://trac.webkit.org/changeset/268704>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411802 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70464319>