Bug 217910 - Import speech tests from WPT
Summary: Import speech tests from WPT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-19 10:41 PDT by Sihui Liu
Modified: 2020-10-19 20:47 PDT (History)
4 users (show)

See Also:


Attachments
Patch (33.07 KB, patch)
2020-10-19 10:45 PDT, Sihui Liu
no flags Details | Formatted Diff | Diff
Patch (66.31 KB, patch)
2020-10-19 12:49 PDT, Sihui Liu
no flags Details | Formatted Diff | Diff
Patch (66.71 KB, patch)
2020-10-19 18:34 PDT, Sihui Liu
no flags Details | Formatted Diff | Diff
Patch for landing (66.95 KB, patch)
2020-10-19 19:57 PDT, Sihui Liu
no flags Details | Formatted Diff | Diff
Patch for landing (66.95 KB, patch)
2020-10-19 19:59 PDT, Sihui Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2020-10-19 10:41:20 PDT
...
Comment 1 Sihui Liu 2020-10-19 10:45:17 PDT
Created attachment 411763 [details]
Patch
Comment 2 youenn fablet 2020-10-19 11:17:41 PDT
Comment on attachment 411763 [details]
Patch

r=me.
Would be good to be able to run the tests that do not crash or time out, even if they fail.

View in context: https://bugs.webkit.org/attachment.cgi?id=411763&action=review

> LayoutTests/TestExpectations:176
> +imported/w3c/web-platform-tests/speech-api/ [ Skip ]

Can we enable them in some cocoa TestExpectations?

> LayoutTests/imported/w3c/web-platform-tests/speech-api/SpeechRecognition-onresult-manual.https.html:1
> +<!DOCTYPE html>

Probably not needed.
The importer is expected to not import these, maybe the https prefix is messing things up.

> LayoutTests/imported/w3c/web-platform-tests/speech-api/SpeechSynthesis-speak-ownership.html:22
> +}, 'Using the same SpeechSynthesisUtterance with two SpeechSynthesis instances');

Can we check in some expected.txt files?
Comment 3 Sihui Liu 2020-10-19 12:49:04 PDT
Created attachment 411778 [details]
Patch
Comment 4 Sihui Liu 2020-10-19 12:49:58 PDT
(In reply to youenn fablet from comment #2)
> Comment on attachment 411763 [details]
> Patch
> 
> r=me.
> Would be good to be able to run the tests that do not crash or time out,
> even if they fail.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411763&action=review
> 
> > LayoutTests/TestExpectations:176
> > +imported/w3c/web-platform-tests/speech-api/ [ Skip ]
> 
> Can we enable them in some cocoa TestExpectations?
> 
Okay, enabled on iOS and mac.

> > LayoutTests/imported/w3c/web-platform-tests/speech-api/SpeechRecognition-onresult-manual.https.html:1
> > +<!DOCTYPE html>
> 
> Probably not needed.
> The importer is expected to not import these, maybe the https prefix is
> messing things up.
> 
I manually removed the -manual test files.

> > LayoutTests/imported/w3c/web-platform-tests/speech-api/SpeechSynthesis-speak-ownership.html:22
> > +}, 'Using the same SpeechSynthesisUtterance with two SpeechSynthesis instances');
> 
> Can we check in some expected.txt files?

Added.
Comment 5 Sihui Liu 2020-10-19 18:34:41 PDT
Created attachment 411824 [details]
Patch
Comment 6 Sihui Liu 2020-10-19 19:57:18 PDT
Created attachment 411830 [details]
Patch for landing
Comment 7 Sihui Liu 2020-10-19 19:59:44 PDT
Created attachment 411831 [details]
Patch for landing
Comment 8 EWS 2020-10-19 20:46:06 PDT
Committed r268713: <https://trac.webkit.org/changeset/268713>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411831 [details].
Comment 9 Radar WebKit Bug Importer 2020-10-19 20:47:20 PDT
<rdar://problem/70468731>