Bug 217899 - Remove the CSSIndividualTransformPropertiesEnabled flag
Summary: Remove the CSSIndividualTransformPropertiesEnabled flag
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
Keywords: InRadar
Depends on:
Blocks: 216512 265400
  Show dependency treegraph
Reported: 2020-10-19 03:21 PDT by Antoine Quint
Modified: 2023-11-27 12:38 PST (History)
17 users (show)

See Also:

Patch (17.80 KB, patch)
2020-10-19 04:46 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (17.86 KB, patch)
2020-10-20 23:26 PDT, Antoine Quint
simon.fraser: review-
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2020-10-19 03:21:26 PDT
Now that the default value for this flag is true, we should remove it altogether.
Comment 1 Radar WebKit Bug Importer 2020-10-19 03:21:52 PDT
Comment 2 Antoine Quint 2020-10-19 04:46:40 PDT
Created attachment 411734 [details]
Comment 3 Simon Fraser (smfr) 2020-10-19 07:31:30 PDT
Comment on attachment 411734 [details]

Too soon. We need to be able to turn off for testing, to see what you broke.
Comment 4 Antoine Quint 2020-10-19 07:59:14 PDT
While I'm in no rush to land this, I want to point out that the changes that are actually guarded by that flag are not very risky compared to the GraphicsLayerCA changes that were related to supporting animation of those properties and which are not guarded by that flag (such as r268483).
Comment 5 Antoine Quint 2020-10-20 23:26:46 PDT
Created attachment 411962 [details]
Comment 6 Simon Fraser (smfr) 2020-10-21 10:50:59 PDT
Comment on attachment 411962 [details]

We leave flags around for a year for testing.
Comment 7 Sam Weinig 2020-10-21 15:07:29 PDT
(In reply to Simon Fraser (smfr) from comment #6)
> Comment on attachment 411962 [details]
> Patch
> We leave flags around for a year for testing.

Thats not a policy I have heard before. It seems kinda reasonable, though I am a bit unclear its actually useful. If we are going to go with this, it would be nice to make this more official, and have some way of following up (since we have tons of flags that should be removed, but never have been). Can you propose a model for how we can ensure we revisit these after a year?
Comment 9 Tim Nguyen (:ntim) 2023-11-26 00:46:29 PST
This is probably removable at this point.
Comment 10 Antoine Quint 2023-11-26 03:29:23 PST
Pull request: https://github.com/WebKit/WebKit/pull/20900
Comment 11 EWS 2023-11-27 00:27:17 PST
Committed 271133@main (3635c66e7e2a): <https://commits.webkit.org/271133@main>

Reviewed commits have been landed. Closing PR #20900 and removing active labels.