Bug 217878 - Remove "lazy offset" optimization from Range to prepare to derive it from SimpleRange
Summary: Remove "lazy offset" optimization from Range to prepare to derive it from Sim...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-17 13:44 PDT by Darin Adler
Modified: 2020-10-17 17:49 PDT (History)
8 users (show)

See Also:

Attachments
Patch (6.09 KB, patch)
2020-10-17 13:51 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2020-10-17 13:44:00 PDT 
Remove "lazy offset" optmization from Range to prepare to derive it from SimpleRange
Comment 1 Darin Adler 2020-10-17 13:51:18 PDT 
Created attachment 411675 [details]
Patch
Comment 2 Darin Adler 2020-10-17 13:52:50 PDT 
Not 100% sure this optimization of Range is important, but it should be relatively simple if I do it a step at a time like this.
Comment 3 Darin Adler 2020-10-17 14:02:18 PDT 
I meant to say:

"Not 100% sure that re-optimizing Range by making functions like startContainer non-virtual gain is critical"
Comment 4 Darin Adler 2020-10-17 14:07:44 PDT 
(In reply to Darin Adler from comment #3)
> non-virtual gain

again
Comment 5 EWS 2020-10-17 17:48:27 PDT 
Committed r268651: <https://trac.webkit.org/changeset/268651>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411675 [details].
Comment 6 Radar WebKit Bug Importer 2020-10-17 17:49:20 PDT 
<rdar://problem/70412495>