Bug 217877 - Convert preferences in WebPreferencesPrivate.h to use @property syntax to make them more manageable
Summary: Convert preferences in WebPreferencesPrivate.h to use @property syntax to mak...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-17 10:45 PDT by Sam Weinig
Modified: 2020-10-26 06:07 PDT (History)
3 users (show)

See Also:

Attachments
Patch (27.22 KB, patch)
2020-10-17 10:46 PDT, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (27.24 KB, patch)
2020-10-17 10:57 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (27.67 KB, patch)
2020-10-17 10:59 PDT, Sam Weinig 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-10-17 10:45:29 PDT 
Convert preferences in WebPreferencesPrivate.h to use @property syntax to make them more manageable
Comment 1 Sam Weinig 2020-10-17 10:46:44 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-10-17 10:57:30 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-10-17 10:59:39 PDT 
Created attachment 411673 [details]
Patch
Comment 4 Simon Fraser (smfr) 2020-10-17 11:06:32 PDT 
Comment on attachment 411673 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411673&action=review

> Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:259
> +@property (nonatomic, retain) NSArray<NSString *> *additionalSupportedImageTypes; // additionalSupportedImageTypes is an array of image UTIs.

Is 'retain' the behavior of the existing code, or should this be 'copy'?
Comment 5 Sam Weinig 2020-10-17 11:09:16 PDT 
(In reply to Simon Fraser (smfr) from comment #4)
> Comment on attachment 411673 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411673&action=review
> 
> > Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:259
> > +@property (nonatomic, retain) NSArray<NSString *> *additionalSupportedImageTypes; // additionalSupportedImageTypes is an array of image UTIs.
> 
> Is 'retain' the behavior of the existing code, or should this be 'copy'?

It's the existing behavior (that one was already an @property), but it should probably be copy.
Comment 6 Sam Weinig 2020-10-17 11:28:51 PDT 
Committed r268646: <https://trac.webkit.org/changeset/268646>
Comment 7 Radar WebKit Bug Importer 2020-10-17 11:29:15 PDT 
<rdar://problem/70409424>