Bug 217862 – Web Inspector: REGRESSION(r266074): line-based JavaScript breakpoints don't hit after reload

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

# STEPS TO REPRODUCE
1. inspect <https://webkit.org>
2. set a breakpoint inside the `DOMContentLoaded` event listener callback in `global.js`
3. reload the page

# EXPECTED
pause

# ACTUAL
no-pause, and the breakpoint shows as unresolved

[Devin Rousso]

Created attachment 411646 [details]
Patch

[EWS]

Committed r268629: <https://trac.webkit.org/changeset/268629>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411646 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70402083>

[Ryan Haddad]

inspector/debugger/breakpoint-resolve-when-script-added.html, added with this change, is frequently timing out on macOS debug bots.

https://results.webkit.org/?suite=layout-tests&test=inspector%2Fdebugger%2Fbreakpoint-resolve-when-script-added.html

[Ryan Haddad]

(In reply to Ryan Haddad from comment #4)
> inspector/debugger/breakpoint-resolve-when-script-added.html, added with
> this change, is frequently timing out on macOS debug bots.
> 
> https://results.webkit.org/?suite=layout-
> tests&test=inspector%2Fdebugger%2Fbreakpoint-resolve-when-script-added.html
Marked the test as slow in https://trac.webkit.org/changeset/268684/webkit

[Blaze Burg]

*** Bug 216807 has been marked as a duplicate of this bug. ***

[Ryan Haddad]

(In reply to Ryan Haddad from comment #4)
> inspector/debugger/breakpoint-resolve-when-script-added.html, added with
> this change, is frequently timing out on macOS debug bots.
> 
> https://results.webkit.org/?suite=layout-
> tests&test=inspector%2Fdebugger%2Fbreakpoint-resolve-when-script-added.html
My statement was incorrect, this is also affecting release bots.

Devin, can you investigate this urgently or should we revert for now?

[Ryan Haddad]

(In reply to Ryan Haddad from comment #7)
> (In reply to Ryan Haddad from comment #4)
> > inspector/debugger/breakpoint-resolve-when-script-added.html, added with
> > this change, is frequently timing out on macOS debug bots.
> > 
> > https://results.webkit.org/?suite=layout-
> > tests&test=inspector%2Fdebugger%2Fbreakpoint-resolve-when-script-added.html
> My statement was incorrect, this is also affecting release bots.
> 
> Devin, can you investigate this urgently or should we revert for now?
Tracking with https://bugs.webkit.org/show_bug.cgi?id=217934