Bug 217843 - [WebAuthn] Add an experimental feature flag: WebAuthenticationModernEnabled
Summary: [WebAuthn] Add an experimental feature flag: WebAuthenticationModernEnabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks: 181943
  Show dependency treegraph
 
Reported: 2020-10-16 14:34 PDT by Jiewen Tan
Modified: 2020-10-16 19:29 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.58 KB, patch)
2020-10-16 14:48 PDT, Jiewen Tan
no flags Details | Formatted Diff | Diff
Patch (4.50 KB, patch)
2020-10-16 16:14 PDT, Jiewen Tan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2020-10-16 14:34:30 PDT
Add an experimental feature flag: WebAuthenticationModernEnabled.
Comment 1 Jiewen Tan 2020-10-16 14:34:45 PDT
<rdar://problem/70384187>
Comment 2 Jiewen Tan 2020-10-16 14:48:56 PDT
Created attachment 411616 [details]
Patch
Comment 3 Jiewen Tan 2020-10-16 16:14:56 PDT
Created attachment 411627 [details]
Patch
Comment 4 Brent Fulgham 2020-10-16 16:16:34 PDT
Comment on attachment 411627 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411627&action=review

r=me

> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:870
> +# FIXME: Is this implemented for WebKitLegacy? If not, this should be excluded from WebKitLegacy entirely.

This doesn't work in WKL. But I don't know how you exclude something in this YAML markup.
Comment 5 Jiewen Tan 2020-10-16 17:22:10 PDT
Comment on attachment 411627 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411627&action=review

Thanks Brent for r+ this patch. Will wait for EWS before landing the patch.

>> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:870
>> +# FIXME: Is this implemented for WebKitLegacy? If not, this should be excluded from WebKitLegacy entirely.
> 
> This doesn't work in WKL. But I don't know how you exclude something in this YAML markup.

I am not sure if that functionality exists at all.
Comment 6 EWS 2020-10-16 19:29:26 PDT
Committed r268628: <https://trac.webkit.org/changeset/268628>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411627 [details].