RESOLVED FIXED 217843
[WebAuthn] Add an experimental feature flag: WebAuthenticationModernEnabled 
https://bugs.webkit.org/show_bug.cgi?id=217843
Summary [WebAuthn] Add an experimental feature flag: WebAuthenticationModernEnabled
Jiewen Tan
Reported 2020-10-16 14:34:30 PDT
Add an experimental feature flag: WebAuthenticationModernEnabled.
Attachments
Patch (4.58 KB, patch)
2020-10-16 14:48 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Patch (4.50 KB, patch)
2020-10-16 16:14 PDT, Jiewen Tan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jiewen Tan
Comment 1 2020-10-16 14:34:45 PDT
<rdar://problem/70384187>
Jiewen Tan
Comment 2 2020-10-16 14:48:56 PDT
Created attachment 411616 [details] Patch
Jiewen Tan
Comment 3 2020-10-16 16:14:56 PDT
Created attachment 411627 [details] Patch
Brent Fulgham
Comment 4 2020-10-16 16:16:34 PDT
Comment on attachment 411627 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411627&action=review r=me > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:870 > +# FIXME: Is this implemented for WebKitLegacy? If not, this should be excluded from WebKitLegacy entirely. This doesn't work in WKL. But I don't know how you exclude something in this YAML markup.
Jiewen Tan
Comment 5 2020-10-16 17:22:10 PDT
Comment on attachment 411627 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411627&action=review Thanks Brent for r+ this patch. Will wait for EWS before landing the patch. >> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:870 >> +# FIXME: Is this implemented for WebKitLegacy? If not, this should be excluded from WebKitLegacy entirely. > > This doesn't work in WKL. But I don't know how you exclude something in this YAML markup. I am not sure if that functionality exists at all.
EWS
Comment 6 2020-10-16 19:29:26 PDT
Committed r268628: <https://trac.webkit.org/changeset/268628> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411627 [details].
Note You need to log in before you can comment on or make changes to this bug.