Bug 217842 – Support accelerated animation of individual transform CSS properties

• Status: RESOLVED
• Resolution: FIXED
• Component: Animations

[Antoine Quint]

Support accelerated animation of individual transform CSS properties

[Radar WebKit Bug Importer]

<rdar://problem/70391914>

[Antoine Quint]

Created attachment 411617 [details]
Patch

[Antoine Quint]

<rdar://problem/70391914>

[Dean Jackson]

Comment on attachment 411617 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411617&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2893
> +        animation.m_beginTime = Seconds::fromNanoseconds(1);

Why not zero? not that it matters

[Antoine Quint]

(In reply to Dean Jackson from comment #4)
> Comment on attachment 411617 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411617&action=review
> 
> > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:2893
> > +        animation.m_beginTime = Seconds::fromNanoseconds(1);
> 
> Why not zero? not that it matters

Because the CA API gives special meaning to zero in this context, using the current time when the CA transaction occur. We need this time to be as early as possible explicitly.

[Antoine Quint]

Committed r268615: <https://trac.webkit.org/changeset/268615>

[Ryan Haddad]

(In reply to Antoine Quint from comment #6)
> Committed r268615: <https://trac.webkit.org/changeset/268615>
As indicated by EWS, these tests are failing on Mojave bots now that the change landed:

webanimations/accelerated-transform-related-animation-property-order.html
webanimations/accelerated-translate-animation-additional-animation-added-in-flight.html
webanimations/accelerated-translate-animation-underlying-transform-changed-in-flight.html
webanimations/accelerated-translate-animation-with-transform.html
webanimations/accelerated-translate-animation.html

https://build.webkit.org/results/Apple-Mojave-Release-WK2-Tests/r268619%20(16992)/results.html

[Dean Jackson]

Updated Test Expectations to skip these tests on Mojave.

r268627

[Ryan Haddad]

(In reply to Dean Jackson from comment #8)
> Updated Test Expectations to skip these tests on Mojave.
> 
> r268627
Thanks! These are image failures, so we’ll need to switch this from Failure to ImageOnlyFailure. I can fix it up later tonight.

[Simon Fraser (smfr)]

Why is it OK to break Mojave? That suggests the patch is wrong.

[Simon Fraser (smfr)]

Like maybe this breaks the !HAVE_CA_WHERE_ADDITIVE_TRANSFORMS_ARE_REVERSED platforms.

[Antoine Quint]

Most likely, I’ll install Mojave and fix those ASAP.

[Simon Fraser (smfr)]

Also Windows is broken.