Bug 217814 - Implement <forgiving-selector-list> for :is/:where
Summary: Implement <forgiving-selector-list> for :is/:where
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari 14
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar, WebExposed
Depends on: 217905 218009
Blocks:
  Show dependency tree / graph
 
Reported: 2020-10-16 05:29 PDT by Anders Ruud
Modified: 2020-10-20 22:29 PDT (History)
16 users (show)

See Also:

Attachments
patch (30.78 KB, patch)
2020-10-20 03:44 PDT, Antti Koivisto 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
patch (2.50 MB, patch)
2020-10-20 06:58 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Ruud 2020-10-16 05:29:43 PDT 
The spec now says :is/:where should parse as a forgiving selector list: https://drafts.csswg.org/selectors/#matches
Comment 1 Radar WebKit Bug Importer 2020-10-16 11:07:39 PDT 
<rdar://problem/70384483>
Comment 2 Antti Koivisto 2020-10-20 03:44:55 PDT 
Created attachment 411851 [details]
patch
Comment 3 Antti Koivisto 2020-10-20 06:58:53 PDT 
Created attachment 411863 [details]
patch
Comment 4 Sam Weinig 2020-10-20 09:36:33 PDT 
Comment on attachment 411863 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411863&action=review

> Source/WebCore/css/parser/CSSSelectorParser.cpp:95
> +    return CSSSelectorList { WTFMove(selectorList) };

I don't think you need to specify CSSSelectorList here if you don't want to.
Comment 5 Antti Koivisto 2020-10-20 09:39:50 PDT 
> I don't think you need to specify CSSSelectorList here if you don't want to.

I had the same thought but it is marked explicit.
Comment 6 Sam Weinig 2020-10-20 09:45:22 PDT 
(In reply to Antti Koivisto from comment #5)
> > I don't think you need to specify CSSSelectorList here if you don't want to.
> 
> I had the same thought but it is marked explicit.

This is what I get for thinking.
Comment 7 EWS 2020-10-20 10:07:30 PDT 
Committed r268741: <https://trac.webkit.org/changeset/268741>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411863 [details].