Bug 21781 – WebCore::Settings should have a maximum decoded image size setting

• Status: RESOLVED
• Resolution: FIXED
• Component: Images

[David Kilzer (:ddkilzer)]

* SUMMARY
It would be nice for WebCore::Settings to have a maximum image size setting to limit the size of images on some platforms.

[David Kilzer (:ddkilzer)]

Created attachment 24549 [details]
Patch v1

[Antti Koivisto]

Comment on attachment 24549 [details]
Patch v1

r=me, with some comments.

+        frame = docLoader() ? docLoader()->frame() : 0;

+    DocLoader* docLoader() const { return m_docLoader; }
+

The CachedResource::m_docLoader is non-zero only in some special cases (it should have a better name). Using m_request->docLoader() covers all cases we care about. These changes are probably not needed.

             // FIXME: I'm not convinced this case can even be hit.

I guess this FIXME can go now. We clearly can hit this case when maxImageSize is limited (plus it was not true even before). 

+        void setMaximumImageSize(size_t size) { m_maximumImageSize = size; }
+        size_t maximumImageSize() const { return m_maximumImageSize; }

How about maximumDecodedImageSize to avoid confusion between encoded and decoded size?

[David Kilzer (:ddkilzer)]

Committed r37803

[David Kilzer (:ddkilzer)]

(In reply to comment #2)
> (From update of attachment 24549 [details] [edit])
> r=me, with some comments.

I made all of these recommended changes before landing.

http://trac.webkit.org/changeset/37803