Bug 217803 - Move even more AudioContext-specific logic out of BaseAudioContext
Summary: Move even more AudioContext-specific logic out of BaseAudioContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 217794
Blocks: 212611
  Show dependency treegraph
 
Reported: 2020-10-15 20:14 PDT by Chris Dumez
Modified: 2020-10-16 11:33 PDT (History)
9 users (show)

See Also:


Attachments
Patch (38.06 KB, patch)
2020-10-15 20:18 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (38.02 KB, patch)
2020-10-16 10:01 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (38.01 KB, patch)
2020-10-16 10:59 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-10-15 20:14:01 PDT
Move even more AudioContext-specific logic out of BaseAudioContext and into AudioContext. In particular, all the logic related to autoplay restrictions, audible state, and platform media session interruptions only apply to AudioContext and not OfflineAudioContext.
Comment 1 Chris Dumez 2020-10-15 20:18:02 PDT
Created attachment 411526 [details]
Patch
Comment 2 Eric Carlson 2020-10-16 08:18:25 PDT
Comment on attachment 411526 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411526&action=review

> Source/WebCore/Modules/webaudio/AudioContext.cpp:390
> +            RELEASE_LOG_IF_ALLOWED("visibilityStateChanged() Suspending playback after going to the background");

Any reason to not use `ALWAYS_LOG(LOGIDENTIFIER, ...)` so the output is in the same format as the rest of the logging from this class?

> Source/WebCore/Modules/webaudio/AudioContext.cpp:395
> +            RELEASE_LOG_IF_ALLOWED("visibilityStateChanged() Resuming playback after entering foreground");

Ditto.
Comment 3 Chris Dumez 2020-10-16 10:01:23 PDT
Created attachment 411590 [details]
Patch
Comment 4 EWS 2020-10-16 10:10:31 PDT
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Comment 5 Chris Dumez 2020-10-16 10:59:47 PDT
Created attachment 411596 [details]
Patch
Comment 6 EWS 2020-10-16 11:32:05 PDT
Committed r268600: <https://trac.webkit.org/changeset/268600>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411596 [details].
Comment 7 Radar WebKit Bug Importer 2020-10-16 11:33:16 PDT
<rdar://problem/70385620>