Bug 217790 - [WebAuthn] Move AppAttestInternal related code from WKA to OpenSource
Summary: [WebAuthn] Move AppAttestInternal related code from WKA to OpenSource
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks: 181943
  Show dependency tree / graph
 
Reported: 2020-10-15 15:53 PDT by Jiewen Tan
Modified: 2020-10-16 00:52 PDT (History)
7 users (show)

See Also:

Attachments
Patch (14.77 KB, patch)
2020-10-15 15:57 PDT, Jiewen Tan 		bfulgham: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for Landing (17.78 KB, patch)
2020-10-15 23:17 PDT, Jiewen Tan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2020-10-15 15:53:04 PDT 
Move AppAttestInternal related code from WKA to OpenSource.
Comment 1 Jiewen Tan 2020-10-15 15:53:29 PDT 
<rdar://problem/59613406>
Comment 2 Jiewen Tan 2020-10-15 15:57:32 PDT 
Created attachment 411503 [details]
Patch
Comment 3 Brent Fulgham 2020-10-15 16:20:49 PDT 
Comment on attachment 411503 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411503&action=review

r=mews

> Source/WebKit/UIProcess/WebAuthentication/Cocoa/AppAttestInternalSoftLink.h:28
> +#import <wtf/SoftLinking.h>

I wonder if you need this if APPLE_ATTESTATION is not defined?

> Source/WebKit/UIProcess/WebAuthentication/Cocoa/AppAttestInternalSoftLink.mm:28
> +#import <wtf/SoftLinking.h>

I wonder if you even need to include this if the build does not have APPLE_ATTESTATION defined?
Comment 4 Brent Fulgham 2020-10-15 16:21:03 PDT 
Looks good, bug please wait for EWS to complete before landing.
Comment 5 Jiewen Tan 2020-10-15 16:54:43 PDT 
(In reply to Brent Fulgham from comment #4)
> Looks good, bug please wait for EWS to complete before landing.

Forgot to add a SPI file. Will upload a patch with that...

Thanks for r+!
Comment 6 Jiewen Tan 2020-10-15 23:14:42 PDT 
Comment on attachment 411503 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411503&action=review

>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/AppAttestInternalSoftLink.h:28
>> +#import <wtf/SoftLinking.h>
> 
> I wonder if you need this if APPLE_ATTESTATION is not defined?

Fixed.

>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/AppAttestInternalSoftLink.mm:28
>> +#import <wtf/SoftLinking.h>
> 
> I wonder if you even need to include this if the build does not have APPLE_ATTESTATION defined?

Fixed.
Comment 7 Jiewen Tan 2020-10-15 23:17:10 PDT 
Created attachment 411537 [details]
Patch for Landing
Comment 8 Jiewen Tan 2020-10-16 00:52:51 PDT 
Committed r268575: <https://trac.webkit.org/changeset/268575>