Bug 217787 - Drop legacy code using AssertionServices
Summary: Drop legacy code using AssertionServices
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-15 14:53 PDT by Chris Dumez
Modified: 2020-10-20 09:25 PDT (History)
9 users (show)

See Also:

Attachments
Patch (41.35 KB, patch)
2020-10-15 14:57 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (39.72 KB, patch)
2020-10-19 14:11 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (39.72 KB, patch)
2020-10-19 14:28 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-10-15 14:53:57 PDT 
Drop legacy code using AssertionServices as this framework is deprecated in favor of RunningBoard. All our code has been ported to RunningBoard already.
Comment 1 Chris Dumez 2020-10-15 14:54:14 PDT 
<rdar://problem/70160942>
Comment 2 Chris Dumez 2020-10-15 14:57:49 PDT 
Created attachment 411495 [details]
Patch
Comment 3 Darin Adler 2020-10-15 15:28:57 PDT 
Comment on attachment 411495 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411495&action=review

> Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:352
> +    return m_rbsAssertion ? m_rbsAssertion.get().valid : false;

Maybe use &&?
Comment 4 Chris Dumez 2020-10-15 16:31:00 PDT 
Hmm. Looks like our iOS EWS is still running iOS 13 and is thus having a bad time... I guess I need to wait until our bots are all upgraded to iOS 14.
Comment 5 Chris Dumez 2020-10-19 14:11:43 PDT 
Created attachment 411795 [details]
Patch
Comment 6 Darin Adler 2020-10-19 14:27:03 PDT 
Comment on attachment 411795 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411795&action=review

> Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:352
> +    return m_rbsAssertion ? m_rbsAssertion.get().valid : false;

Maybe &&
Comment 7 Chris Dumez 2020-10-19 14:27:36 PDT 
(In reply to Darin Adler from comment #6)
> Comment on attachment 411795 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411795&action=review
> 
> > Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:352
> > +    return m_rbsAssertion ? m_rbsAssertion.get().valid : false;
> 
> Maybe &&

Oh, I missed that. Will fix.
Comment 8 Chris Dumez 2020-10-19 14:28:20 PDT 
Created attachment 411800 [details]
Patch
Comment 9 EWS 2020-10-20 09:25:48 PDT 
Committed r268736: <https://trac.webkit.org/changeset/268736>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411800 [details].