Bug 217787 – Drop legacy code using AssertionServices

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Drop legacy code using AssertionServices as this framework is deprecated in favor of RunningBoard. All our code has been ported to RunningBoard already.

[Chris Dumez]

<rdar://problem/70160942>

[Chris Dumez]

Created attachment 411495 [details]
Patch

[Darin Adler]

Comment on attachment 411495 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411495&action=review

> Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:352
> +    return m_rbsAssertion ? m_rbsAssertion.get().valid : false;

Maybe use &&?

[Chris Dumez]

Hmm. Looks like our iOS EWS is still running iOS 13 and is thus having a bad time... I guess I need to wait until our bots are all upgraded to iOS 14.

[Chris Dumez]

Created attachment 411795 [details]
Patch

[Darin Adler]

Comment on attachment 411795 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411795&action=review

> Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:352
> +    return m_rbsAssertion ? m_rbsAssertion.get().valid : false;

Maybe &&

[Chris Dumez]

(In reply to Darin Adler from comment #6)
> Comment on attachment 411795 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411795&action=review
> 
> > Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm:352
> > +    return m_rbsAssertion ? m_rbsAssertion.get().valid : false;
> 
> Maybe &&

Oh, I missed that. Will fix.

[Chris Dumez]

Created attachment 411800 [details]
Patch

[EWS]

Committed r268736: <https://trac.webkit.org/changeset/268736>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411800 [details].