Bug 217785 - Refactor {WebAccessibilityObjectWrapper convertRectToSpace] so that the platform-specific code is in their corresponding AX object platform implementations.
Summary: Refactor {WebAccessibilityObjectWrapper convertRectToSpace] so that the platf...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-15 14:38 PDT by Andres Gonzalez
Modified: 2020-10-16 06:04 PDT (History)
9 users (show)

See Also:

Attachments
Patch (18.45 KB, patch)
2020-10-15 14:55 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (18.40 KB, patch)
2020-10-15 19:31 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-10-15 14:38:13 PDT 
Refactor {WebAccessibilityObjectWrapper convertRectToSpace] so that the platform-specific code is in their corresponding AX object platform implementations.
Comment 1 Andres Gonzalez 2020-10-15 14:55:25 PDT 
Created attachment 411492 [details]
Patch
Comment 2 chris fleizach 2020-10-15 16:08:56 PDT 
Comment on attachment 411492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411492&action=review

> Source/WebCore/accessibility/AccessibilityObject.h:444
> +    NSView * topDocumentFrameView() const override;

* in the wrong place

> Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:50
> +NSView * AccessibilityObject::topDocumentFrameView() const

* in wrong place

> Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:80
> +    WAKView* documentView = frameView ? frameView->documentView() : nullptr;

* on wrong side

> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:583
> +    NSView * topDocumentFrameView() const override { return nil; } // FIXME: implement, currently only used on iOS.

* wrong place

> Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:73
> +NSView * AccessibilityObject::topDocumentFrameView() const

* in wrong place

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1983
> +    return [NSValue valueWithPoint:NSPointFromCGPoint(cgRect.origin)];

I think you can do

return @(cgRect.origin);

now
Comment 3 Andres Gonzalez 2020-10-15 19:31:34 PDT 
Created attachment 411522 [details]
Patch
Comment 4 Andres Gonzalez 2020-10-15 19:34:15 PDT 
(In reply to chris fleizach from comment #2)
> Comment on attachment 411492 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411492&action=review
> 
> > Source/WebCore/accessibility/AccessibilityObject.h:444
> > +    NSView * topDocumentFrameView() const override;
> 
> * in the wrong place

Fixed.
> 
> > Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:50
> > +NSView * AccessibilityObject::topDocumentFrameView() const
> 
> * in wrong place

Fixed.
> 
> > Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:80
> > +    WAKView* documentView = frameView ? frameView->documentView() : nullptr;
> 
> * on wrong side

Fixed.
> 
> > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:583
> > +    NSView * topDocumentFrameView() const override { return nil; } // FIXME: implement, currently only used on iOS.
> 
> * wrong place

Fixed.
> 
> > Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:73
> > +NSView * AccessibilityObject::topDocumentFrameView() const
> 
> * in wrong place

Fixed.
> 
> > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1983
> > +    return [NSValue valueWithPoint:NSPointFromCGPoint(cgRect.origin)];
> 
> I think you can do
> 
> return @(cgRect.origin);
> 
> now

Yes, fixed. Thanks.
Comment 5 EWS 2020-10-16 06:03:54 PDT 
Committed r268585: <https://trac.webkit.org/changeset/268585>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411522 [details].
Comment 6 Radar WebKit Bug Importer 2020-10-16 06:04:18 PDT 
<rdar://problem/70375535>