Bug 217781 - [macOS] Issue temporary sandbox extension to the Launch Services daemon
Summary: [macOS] Issue temporary sandbox extension to the Launch Services daemon
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-15 13:57 PDT by Per Arne Vollan
Modified: 2020-10-15 18:07 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.43 KB, patch)
2020-10-15 14:19 PDT, Per Arne Vollan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (5.43 KB, patch)
2020-10-15 15:46 PDT, Per Arne Vollan 		bfulgham: review+
Details | Formatted Diff | Diff
Patch (5.52 KB, patch)
2020-10-15 17:03 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-10-15 13:57:37 PDT 
To support blocking of the Launch Services daemon in the WebContent process, issue temporary sandbox extension to this service on macOS.
Comment 1 Radar WebKit Bug Importer 2020-10-15 13:58:10 PDT 
<rdar://problem/70350924>
Comment 2 Per Arne Vollan 2020-10-15 14:19:52 PDT 
Created attachment 411487 [details]
Patch
Comment 3 Per Arne Vollan 2020-10-15 15:46:50 PDT 
Created attachment 411500 [details]
Patch
Comment 4 Brent Fulgham 2020-10-15 16:13:32 PDT 
Comment on attachment 411500 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411500&action=review

r=me

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:290
> +

Can you add a FIXME here?

FIXME (<rdar://problem/70345312): Notify LaunchServices that we will be disconnecting.
Comment 5 Per Arne Vollan 2020-10-15 17:03:05 PDT 
Created attachment 411512 [details]
Patch
Comment 6 Per Arne Vollan 2020-10-15 17:13:04 PDT 
(In reply to Brent Fulgham from comment #4)
> Comment on attachment 411500 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411500&action=review
> 
> r=me
> 
> > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:290
> > +
> 
> Can you add a FIXME here?
> 
> FIXME (<rdar://problem/70345312): Notify LaunchServices that we will be
> disconnecting.

I have uploaded a new patch with the FIXME.

Thanks for reviewing!
Comment 7 EWS 2020-10-15 18:07:32 PDT 
Committed r268567: <https://trac.webkit.org/changeset/268567>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411512 [details].