Bug 217749 – [Cocoa] Don't change the text matrix multiple times inside FontCascade::drawGlyphs()

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[Cocoa] Don't change the text matrix multiple times inside FontCascade::drawGlyphs()

[Myles C. Maxfield]

Created attachment 411415 [details]
Patch

[Sam Weinig]

Comment on attachment 411415 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411415&action=review

> Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp:66
> +    static NeverDestroyed<AffineTransform> result(0, -1, 1, 0, 0, 0);

I don't think a NeverDestroyed should be needed here, as AffineTransform should have a trivial destructor. We should probably make constructions of AffineTransform constexpr (given it is built on std::array, this should be easy enough) so we can make this even moar const. (none of that is needed for this change, just writing this here to note it).

> Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp:85
> +    CGPoint position = FloatPoint(point.x(), point.y() + ascentDelta);

Seems a bit weird to make a CGPoint this way. Any reason not to use CGPointMake directly?

[Simon Fraser (smfr)]

Comment on attachment 411415 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411415&action=review

> Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp:144
> +    if (!platformData.isColorBitmapFont())

Why are color bitmap fonts special?

[Myles C. Maxfield]

Comment on attachment 411415 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411415&action=review

>> Source/WebCore/platform/graphics/coretext/FontCascadeCoreText.cpp:144
>> +    if (!platformData.isColorBitmapFont())
> 
> Why are color bitmap fonts special?

I have no idea 😅 This branch is probably wrong, but this patch just moves the code around. I've filed https://bugs.webkit.org/show_bug.cgi?id=217767 to see if we can remove it.

[Myles C. Maxfield]

Comment on attachment 411415 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411415&action=review

> Source/WebCore/ChangeLog:18
> +        calls, we have now way of knowing whether it was modified by WebKit or

now way

[Myles C. Maxfield]

Committed r268561: <https://trac.webkit.org/changeset/268561>

[Radar WebKit Bug Importer]

<rdar://problem/70358054>