RESOLVED FIXED 217743
Vectorize downmixing in AudioBus::createByMixingToMono() 
https://bugs.webkit.org/show_bug.cgi?id=217743
Summary Vectorize downmixing in AudioBus::createByMixingToMono()
Chris Dumez
Reported 2020-10-14 18:11:05 PDT
Vectorize downmixing in AudioBus::createByMixingToMono().
Attachments
Patch (4.26 KB, patch)
2020-10-14 18:12 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (4.23 KB, patch)
2020-10-14 18:25 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-10-14 18:12:47 PDT
Created attachment 411391 [details] Patch
Darin Adler
Comment 2 2020-10-14 18:20:57 PDT
Comment on attachment 411391 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411391&action=review > Source/WebCore/platform/audio/VectorMath.cpp:697 > + VectorMath::add(inputVector1, inputVector2, outputVector, numberOfElementsToProcess); > + VectorMath::multiplyByScalar(outputVector, scalar, outputVector, numberOfElementsToProcess); We are in the VectorMath namespace, so no need to restate the namespace as a prefix.
Chris Dumez
Comment 3 2020-10-14 18:25:15 PDT
Created attachment 411393 [details] Patch
EWS
Comment 4 2020-10-14 19:23:26 PDT
Committed r268505: <https://trac.webkit.org/changeset/268505> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411393 [details].
Radar WebKit Bug Importer
Comment 5 2020-10-14 19:24:26 PDT
<rdar://problem/70318098>
Note You need to log in before you can comment on or make changes to this bug.