Bug 217743 - Vectorize downmixing in AudioBus::createByMixingToMono()
Summary: Vectorize downmixing in AudioBus::createByMixingToMono()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency tree / graph
 
Reported: 2020-10-14 18:11 PDT by Chris Dumez
Modified: 2020-10-14 19:24 PDT (History)
10 users (show)

See Also:

Attachments
Patch (4.26 KB, patch)
2020-10-14 18:12 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (4.23 KB, patch)
2020-10-14 18:25 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-10-14 18:11:05 PDT 
Vectorize downmixing in AudioBus::createByMixingToMono().
Comment 1 Chris Dumez 2020-10-14 18:12:47 PDT 
Created attachment 411391 [details]
Patch
Comment 2 Darin Adler 2020-10-14 18:20:57 PDT 
Comment on attachment 411391 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411391&action=review

> Source/WebCore/platform/audio/VectorMath.cpp:697
> +    VectorMath::add(inputVector1, inputVector2, outputVector, numberOfElementsToProcess);
> +    VectorMath::multiplyByScalar(outputVector, scalar, outputVector, numberOfElementsToProcess);

We are in the VectorMath namespace, so no need to restate the namespace as a prefix.
Comment 3 Chris Dumez 2020-10-14 18:25:15 PDT 
Created attachment 411393 [details]
Patch
Comment 4 EWS 2020-10-14 19:23:26 PDT 
Committed r268505: <https://trac.webkit.org/changeset/268505>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411393 [details].
Comment 5 Radar WebKit Bug Importer 2020-10-14 19:24:26 PDT 
<rdar://problem/70318098>