Bug 217723 – [Testing] Generate test header key map for DumpRenderTree

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

[Testing] Generate test header key map for DumpRenderTree

[Sam Weinig]

Created attachment 411358 [details]
Patch

[Peng Liu]

Comment on attachment 411358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411358&action=review

> Tools/ChangeLog:9
> +        to begin support for supporting any WebPreference from DumpRenderTree. This does not actually

This change log sounds strange. :-)

[Sam Weinig]

(In reply to Peng Liu from comment #2)
> Comment on attachment 411358 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411358&action=review
> 
> > Tools/ChangeLog:9
> > +        to begin support for supporting any WebPreference from DumpRenderTree. This does not actually
> 
> This change log sounds strange. :-)

Do you mean just the redundant statement "begin support for supporting"? Or are you referring to something else?

[Peng Liu]

Comment on attachment 411358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411358&action=review

>>> Tools/ChangeLog:9
>>> +        to begin support for supporting any WebPreference from DumpRenderTree. This does not actually
>> 
>> This change log sounds strange. :-)
> 
> Do you mean just the redundant statement "begin support for supporting"? Or are you referring to something else?

"begin support for supporting", and "basic test header command key type generation".

[Sam Weinig]

(In reply to Peng Liu from comment #4)
> Comment on attachment 411358 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411358&action=review
> 
> >>> Tools/ChangeLog:9
> >>> +        to begin support for supporting any WebPreference from DumpRenderTree. This does not actually
> >> 
> >> This change log sounds strange. :-)
> > 
> > Do you mean just the redundant statement "begin support for supporting"? Or are you referring to something else?
> 
> "begin support for supporting", and "basic test header command key type
> generation".

The former is mistake. The latter is meaningful. 

"test header" -> the <!-- webkit-test-runner [ ModernMediaControlsEnabled=true ] --> comments.
"command key" -> the name of the commands in those headers, e.g. ModernMediaControlsEnabled

[Peng Liu]

Comment on attachment 411358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411358&action=review

>>>>> Tools/ChangeLog:9
>>>>> +        to begin support for supporting any WebPreference from DumpRenderTree. This does not actually
>>>> 
>>>> This change log sounds strange. :-)
>>> 
>>> Do you mean just the redundant statement "begin support for supporting"? Or are you referring to something else?
>> 
>> "begin support for supporting", and "basic test header command key type generation".
> 
> The former is mistake. The latter is meaningful. 
> 
> "test header" -> the <!-- webkit-test-runner [ ModernMediaControlsEnabled=true ] --> comments.
> "command key" -> the name of the commands in those headers, e.g. ModernMediaControlsEnabled

I see! Thanks!

[Sam Weinig]

Committed r268495: <https://trac.webkit.org/changeset/268495>

[Radar WebKit Bug Importer]

<rdar://problem/70311807>

[Ryan Haddad]

Reverted r268495, r268571, and r268682 for reason:

Caused failures for some internal build configurations

Committed r268693: <https://trac.webkit.org/changeset/268693>

[Ryan Haddad]

Reverted r268693 for reason:

Re-landing these changes as the underlying issue may have been with CI infrastructure (and should now be resolved)

Committed r268705: <https://trac.webkit.org/changeset/268705>