WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
217723
[Testing] Generate test header key map for DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=217723
Summary
[Testing] Generate test header key map for DumpRenderTree
Sam Weinig
Reported
2020-10-14 11:59:44 PDT
[Testing] Generate test header key map for DumpRenderTree
Attachments
Patch
(19.02 KB, patch)
2020-10-14 12:11 PDT
,
Sam Weinig
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2020-10-14 12:11:45 PDT
Created
attachment 411358
[details]
Patch
Peng Liu
Comment 2
2020-10-14 13:32:56 PDT
Comment on
attachment 411358
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=411358&action=review
> Tools/ChangeLog:9 > + to begin support for supporting any WebPreference from DumpRenderTree. This does not actually
This change log sounds strange. :-)
Sam Weinig
Comment 3
2020-10-14 13:36:38 PDT
(In reply to Peng Liu from
comment #2
)
> Comment on
attachment 411358
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=411358&action=review
> > > Tools/ChangeLog:9 > > + to begin support for supporting any WebPreference from DumpRenderTree. This does not actually > > This change log sounds strange. :-)
Do you mean just the redundant statement "begin support for supporting"? Or are you referring to something else?
Peng Liu
Comment 4
2020-10-14 13:40:31 PDT
Comment on
attachment 411358
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=411358&action=review
>>> Tools/ChangeLog:9 >>> + to begin support for supporting any WebPreference from DumpRenderTree. This does not actually >> >> This change log sounds strange. :-) > > Do you mean just the redundant statement "begin support for supporting"? Or are you referring to something else?
"begin support for supporting", and "basic test header command key type generation".
Sam Weinig
Comment 5
2020-10-14 13:45:30 PDT
(In reply to Peng Liu from
comment #4
)
> Comment on
attachment 411358
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=411358&action=review
> > >>> Tools/ChangeLog:9 > >>> + to begin support for supporting any WebPreference from DumpRenderTree. This does not actually > >> > >> This change log sounds strange. :-) > > > > Do you mean just the redundant statement "begin support for supporting"? Or are you referring to something else? > > "begin support for supporting", and "basic test header command key type > generation".
The former is mistake. The latter is meaningful. "test header" -> the <!-- webkit-test-runner [ ModernMediaControlsEnabled=true ] --> comments. "command key" -> the name of the commands in those headers, e.g. ModernMediaControlsEnabled
Peng Liu
Comment 6
2020-10-14 13:47:43 PDT
Comment on
attachment 411358
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=411358&action=review
>>>>> Tools/ChangeLog:9 >>>>> + to begin support for supporting any WebPreference from DumpRenderTree. This does not actually >>>> >>>> This change log sounds strange. :-) >>> >>> Do you mean just the redundant statement "begin support for supporting"? Or are you referring to something else? >> >> "begin support for supporting", and "basic test header command key type generation". > > The former is mistake. The latter is meaningful. > > "test header" -> the <!-- webkit-test-runner [ ModernMediaControlsEnabled=true ] --> comments. > "command key" -> the name of the commands in those headers, e.g. ModernMediaControlsEnabled
I see! Thanks!
Sam Weinig
Comment 7
2020-10-14 15:52:58 PDT
Committed
r268495
: <
https://trac.webkit.org/changeset/268495
>
Radar WebKit Bug Importer
Comment 8
2020-10-14 15:53:16 PDT
<
rdar://problem/70311807
>
Ryan Haddad
Comment 9
2020-10-19 15:08:12 PDT
Reverted
r268495
,
r268571
, and
r268682
for reason: Caused failures for some internal build configurations Committed
r268693
: <
https://trac.webkit.org/changeset/268693
>
Ryan Haddad
Comment 10
2020-10-19 17:52:21 PDT
Reverted
r268693
for reason: Re-landing these changes as the underlying issue may have been with CI infrastructure (and should now be resolved) Committed
r268705
: <
https://trac.webkit.org/changeset/268705
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug