Bug 217711 - Refactor HighlightData
Summary: Refactor HighlightData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-14 09:11 PDT by Megan Gardner
Modified: 2020-10-14 13:43 PDT (History)
16 users (show)

See Also:

Attachments
Patch (60.62 KB, patch)
2020-10-14 09:16 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (46.30 KB, patch)
2020-10-14 09:55 PDT, Megan Gardner 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (46.35 KB, patch)
2020-10-14 10:06 PDT, Megan Gardner 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (45.78 KB, patch)
2020-10-14 10:14 PDT, Megan Gardner 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (58.58 KB, patch)
2020-10-14 10:35 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2020-10-14 09:11:04 PDT 
Refactor HighlightData
Comment 1 Megan Gardner 2020-10-14 09:16:30 PDT 
Created attachment 411329 [details]
Patch
Comment 2 Megan Gardner 2020-10-14 09:55:17 PDT 
Created attachment 411338 [details]
Patch
Comment 3 Megan Gardner 2020-10-14 10:06:27 PDT 
Created attachment 411343 [details]
Patch
Comment 4 Megan Gardner 2020-10-14 10:14:20 PDT 
Created attachment 411345 [details]
Patch
Comment 5 Megan Gardner 2020-10-14 10:35:10 PDT 
Created attachment 411347 [details]
Patch
Comment 6 Darin Adler 2020-10-14 11:54:02 PDT 
Comment on attachment 411347 [details]
Patch

This looks great. I have some additional ideas for refinement here; HighlightData itself can be simplified further; I’m not sure we even need the concept of RenderRange; we can probably just use SimpleRange instead.
Comment 7 EWS 2020-10-14 13:42:29 PDT 
Committed r268484: <https://trac.webkit.org/changeset/268484>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411347 [details].
Comment 8 Radar WebKit Bug Importer 2020-10-14 13:43:21 PDT 
<rdar://problem/70306552>