Bug 217710 - Introduce a RemoteAudioSourceProvider to receive audio samples for web audio from GPUProcess
Summary: Introduce a RemoteAudioSourceProvider to receive audio samples for web audio ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks: 217704
  Show dependency treegraph
 
Reported: 2020-10-14 08:35 PDT by youenn fablet
Modified: 2020-10-15 04:37 PDT (History)
10 users (show)

See Also:


Attachments
Patch (38.27 KB, patch)
2020-10-14 08:43 PDT, youenn fablet
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (38.81 KB, patch)
2020-10-14 08:48 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (40.10 KB, patch)
2020-10-14 09:11 PDT, youenn fablet
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (41.64 KB, patch)
2020-10-14 09:30 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (62.01 KB, patch)
2020-10-14 23:54 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (61.85 KB, patch)
2020-10-15 03:49 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-10-14 08:35:43 PDT
Introduce a RemoteAudioSourceProvider to receive audio samples for web audio from GPUProcess
Comment 1 youenn fablet 2020-10-14 08:43:43 PDT
Created attachment 411326 [details]
Patch
Comment 2 youenn fablet 2020-10-14 08:48:13 PDT
Created attachment 411327 [details]
Patch
Comment 3 youenn fablet 2020-10-14 09:11:33 PDT
Created attachment 411328 [details]
Patch
Comment 4 youenn fablet 2020-10-14 09:30:29 PDT
Created attachment 411331 [details]
Patch
Comment 5 Eric Carlson 2020-10-14 12:00:56 PDT
Comment on attachment 411331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411331&action=review

> Source/WebCore/ChangeLog:9
> +        This allows reusing WebAudioSourceProviderAVFObjC for samples coming from video playback living in GPUProcess.

s/video playback/audio playback/

> Source/WebCore/platform/mediastream/mac/MediaStreamTrackAudioSourceProviderAVFObjC.h:36
> +class MediaStreamTrackAudioSourceProviderAVFObjC final

Nit: it looks like this class doesn't use AVFoundation, so we could rename it. `MediaStreamTrackAudioSourceProviderCocoa` maybe?

> Source/WebCore/platform/mediastream/mac/WebAudioSourceProviderAVFObjC.h:54
> +class WEBCORE_EXPORT WebAudioSourceProviderAVFObjC

Ditto.
Comment 6 youenn fablet 2020-10-14 23:54:58 PDT
Created attachment 411412 [details]
Patch for landing
Comment 7 EWS 2020-10-15 03:00:50 PDT
ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.
Comment 8 youenn fablet 2020-10-15 03:49:51 PDT
Created attachment 411421 [details]
Patch for landing
Comment 9 EWS 2020-10-15 04:36:51 PDT
Committed r268521: <https://trac.webkit.org/changeset/268521>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411421 [details].
Comment 10 Radar WebKit Bug Importer 2020-10-15 04:37:16 PDT
<rdar://problem/70331177>