Bug 217706 - [macOS] Issue sandbox extension to additional icon service when attachment element is enabled.
Summary: [macOS] Issue sandbox extension to additional icon service when attachment el...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-14 07:03 PDT by Per Arne Vollan
Modified: 2020-10-14 15:19 PDT (History)
2 users (show)

See Also:


Attachments
Patch (6.08 KB, patch)
2020-10-14 07:12 PDT, Per Arne Vollan
bfulgham: review+
Details | Formatted Diff | Diff
Patch (6.59 KB, patch)
2020-10-14 14:44 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-10-14 07:03:54 PDT
Issue sandbox extension to 'com.apple.iconservices.store' when attachment element is enabled on macOS.
Comment 1 Radar WebKit Bug Importer 2020-10-14 07:04:16 PDT
<rdar://problem/70291100>
Comment 2 Per Arne Vollan 2020-10-14 07:12:14 PDT
Created attachment 411319 [details]
Patch
Comment 3 Brent Fulgham 2020-10-14 14:42:36 PDT
Comment on attachment 411319 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411319&action=review

r=me

> Source/WebKit/UIProcess/WebPageProxy.cpp:7843
> +        parameters.attachmentElementExtensionHandles = SandboxExtension::createHandlesForMachLookup(attachmentElementServices(), WTF::nullopt);

Much tidier!
Comment 4 Per Arne Vollan 2020-10-14 14:44:52 PDT
Created attachment 411375 [details]
Patch
Comment 5 Per Arne Vollan 2020-10-14 14:46:04 PDT
Comment on attachment 411375 [details]
Patch

Thanks for reviewing!
Comment 6 EWS 2020-10-14 15:19:24 PDT
Committed r268492: <https://trac.webkit.org/changeset/268492>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411375 [details].