Bug 217705 - MediaRecorder .stop should not throw in Inactive state
Summary: MediaRecorder .stop should not throw in Inactive state
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-14 05:57 PDT by youenn fablet
Modified: 2020-10-18 12:51 PDT (History)
13 users (show)

See Also:

Attachments
Patch (8.56 KB, patch)
2020-10-14 06:00 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-10-14 05:57:20 PDT 
MediaRecorder .stop should not throw in Inactive state
Comment 1 youenn fablet 2020-10-14 05:57:59 PDT 
See https://github.com/w3c/mediacapture-record/pull/158
Comment 2 youenn fablet 2020-10-14 06:00:11 PDT 
Created attachment 411316 [details]
Patch
Comment 3 youenn fablet 2020-10-14 06:01:01 PDT 
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/26114
Comment 4 EWS Watchlist 2020-10-14 06:01:04 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 5 EWS 2020-10-14 11:56:09 PDT 
Committed r268477: <https://trac.webkit.org/changeset/268477>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411316 [details].
Comment 6 Radar WebKit Bug Importer 2020-10-14 11:57:25 PDT 
<rdar://problem/70302371>
Comment 7 Darin Adler 2020-10-18 12:51:00 PDT 
Comment on attachment 411316 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411316&action=review

> Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp:216
> -    return { };
> +    return;

Should just delete this.