Bug 217667 – [WebIDL] Add support for identifiers with dashes ('-')

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

[WebIDL] Add support for identifiers with hyphens ('-')

[Sam Weinig]

Created attachment 411258 [details]
Patch

[Darin Adler]

Comment on attachment 411258 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411258&action=review

> Source/WebCore/ChangeLog:12
> +        Update identifer regular expression to match current spec which allows for dashes ('-').

identifer

> Source/WebCore/ChangeLog:19
> +        underscores ('__'), as that is not likely to ever appear in an identifier.

C++ reserves identifiers containing double underscores. https://en.cppreference.com/w/cpp/language/identifiers

Maybe "_dash_"?

[Sam Weinig]

(In reply to Darin Adler from comment #2)
> Comment on attachment 411258 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411258&action=review
> 
> > Source/WebCore/ChangeLog:12
> > +        Update identifer regular expression to match current spec which allows for dashes ('-').
> 
> identifer
> 
> > Source/WebCore/ChangeLog:19
> > +        underscores ('__'), as that is not likely to ever appear in an identifier.
> 
> C++ reserves identifiers containing double underscores.
> https://en.cppreference.com/w/cpp/language/identifiers

Oh, interesting. I for some reason always thought it was double underscores at the beginning of an identifier, but no, it's anywhere.

> 
> Maybe "_dash_"?

That seems good. Will update. Thanks.

[Sam Weinig]

Created attachment 411264 [details]
Patch

[Darin Adler]

Unicode names the ASCII character "hyphen-minus". So we are being super colloquial calling it a "dash". But that word seems friendly enough.

[Sam Weinig]

(In reply to Darin Adler from comment #5)
> Unicode names the ASCII character "hyphen-minus". So we are being super
> colloquial calling it a "dash". But that word seems friendly enough.

Sorry, a bit unclear here. Are you suggesting I change it from "_dash_" to something else?

[Darin Adler]

No. Just musing on whether this character is a "dash" or a "hyphen", don’t really care which name we chose.

[EWS]

Committed r268435: <https://trac.webkit.org/changeset/268435>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411264 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70272997>

[Sam Weinig]

(In reply to Darin Adler from comment #7)
> No. Just musing on whether this character is a "dash" or a "hyphen", don’t
> really care which name we chose.

Heh. I clearly had the same musing as the test case still uses "hyphen" :). I went back and forth a few times.