Bug 217663 – WebAudio tests are crashing in debug when enabling the GPU process

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Audio

[Chris Dumez]

WebAudio tests are crashing in debug when enabling the GPU process because it does audio processing on the WebContent process' main thread.

[Chris Dumez]

Created attachment 411237 [details]
Patch

[Chris Dumez]

Created attachment 411238 [details]
Patch

[Chris Dumez]

Created attachment 411240 [details]
Patch

[Geoffrey Garen]

Comment on attachment 411240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411240&action=review

r=me

> Source/WTF/ChangeLog:13
> +        deque (since the queue is empty).

dequeue

> Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:115
> +                    audioBus->setChannelMemory(i, (float*)buffers[i]->data(), framesToProcess);

static_cast<float*>

[Chris Dumez]

Created attachment 411245 [details]
Patch

[Peng Liu]

Comment on attachment 411245 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411245&action=review

> Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:46
> +constexpr size_t fifoSize = 96 * WebCore::AudioUtilities::renderQuantumSize;

Could you explain how did you choose the number 96? Thanks!

> Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:87
>      void render(AudioBus* sourceBus, AudioBus* destinationBus, size_t framesToProcess, const WebCore::AudioIOPosition& outputPosition) override

Nit. Looks like "sourceBus" is not used?

> Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:140
> +    WebCore::PushPullFIFO m_fifo;

I like this change!

[Chris Dumez]

(In reply to Peng Liu from comment #6)
> Comment on attachment 411245 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411245&action=review
> 
> > Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:46
> > +constexpr size_t fifoSize = 96 * WebCore::AudioUtilities::renderQuantumSize;
> 
> Could you explain how did you choose the number 96? Thanks!

Oh, I used the same size as the fifo queue in AudioDestinationCocoa.mm. I will add a comment.

> 
> > Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:87
> >      void render(AudioBus* sourceBus, AudioBus* destinationBus, size_t framesToProcess, const WebCore::AudioIOPosition& outputPosition) override
> 
> Nit. Looks like "sourceBus" is not used?
> 
> > Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:140
> > +    WebCore::PushPullFIFO m_fifo;
> 
> I like this change!

[Chris Dumez]

Created attachment 411247 [details]
Patch

[EWS]

Committed r268423: <https://trac.webkit.org/changeset/268423>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411247 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70267708>