Bug 217661 – transform-origin is applied on top of invidivual CSS transform properties on composited layers

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Antoine Quint]

transform-origin is applied on top of invidivual CSS transform properties on composited layers

[Radar WebKit Bug Importer]

<rdar://problem/70259960>

[Antoine Quint]

Created attachment 411234 [details]
Patch

[Antoine Quint]

<rdar://problem/70259960>

[Simon Fraser (smfr)]

Comment on attachment 411234 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411234&action=review

> Source/WebCore/rendering/style/RenderStyle.cpp:1389
> +    bool applyTransformOrigin = options.contains(RenderStyle::TransformOperationOption::TransformOrigin) && (m_rareNonInheritedData->rotate || m_rareNonInheritedData->scale || transformOperations.affectedByTransformOrigin());

m_rareNonInheritedData->rotate and m_rareNonInheritedData->scale may still be no-op values.

[Antoine Quint]

(In reply to Simon Fraser (smfr) from comment #4)
> Comment on attachment 411234 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411234&action=review
> 
> > Source/WebCore/rendering/style/RenderStyle.cpp:1389
> > +    bool applyTransformOrigin = options.contains(RenderStyle::TransformOperationOption::TransformOrigin) && (m_rareNonInheritedData->rotate || m_rareNonInheritedData->scale || transformOperations.affectedByTransformOrigin());
> 
> m_rareNonInheritedData->rotate and m_rareNonInheritedData->scale may still
> be no-op values.

I'll add a affectedByTransformOrigin() call for those as well in the commit.

[Antoine Quint]

Committed r268444: <https://trac.webkit.org/changeset/268444>