Bug 217657 - [LFC] Use the term overridden instead of override to indicate priority values
Summary: [LFC] Use the term overridden instead of override to indicate priority values
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-13 09:31 PDT by zalan
Modified: 2020-10-14 07:01 PDT (History)
6 users (show)

See Also:


Attachments
Patch (49.34 KB, patch)
2020-10-13 09:36 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-10-13 09:31:37 PDT
When a particular geometry value should be used instead of the computed value.
Comment 1 zalan 2020-10-13 09:36:36 PDT
Created attachment 411227 [details]
Patch
Comment 2 Antti Koivisto 2020-10-14 06:36:03 PDT
Comment on attachment 411227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411227&action=review

> Source/WebCore/ChangeLog:8
> +        The OverriddenHorizontal/Vertical structures are used to pass in priority values (e.g. use the "max-height" value instead of the computed "height" value) to geometry computation functions.

Overridden is still bit vague. Like why? Maybe there are more descriptive terms that could be used for these?
Comment 3 zalan 2020-10-14 06:38:58 PDT
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 411227 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411227&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        The OverriddenHorizontal/Vertical structures are used to pass in priority values (e.g. use the "max-height" value instead of the computed "height" value) to geometry computation functions.
> 
> Overridden is still bit vague. Like why? Maybe there are more descriptive
> terms that could be used for these?
Yeah, I agree. Can't think of anything descriptive (and less than 1024 characters long) name right now though.
Comment 4 zalan 2020-10-14 06:45:28 PDT
(In reply to zalan from comment #3)
> (In reply to Antti Koivisto from comment #2)
> > Comment on attachment 411227 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=411227&action=review
> > 
> > > Source/WebCore/ChangeLog:8
> > > +        The OverriddenHorizontal/Vertical structures are used to pass in priority values (e.g. use the "max-height" value instead of the computed "height" value) to geometry computation functions.
> > 
> > Overridden is still bit vague. Like why? Maybe there are more descriptive
> > terms that could be used for these?
> Yeah, I agree. Can't think of anything descriptive (and less than 1024
> characters long) name right now though.
The long name would be something like UseTheseValuesForCertainPropertiesInsteadOfTheirComputedValues
Comment 5 EWS 2020-10-14 07:00:53 PDT
Committed r268456: <https://trac.webkit.org/changeset/268456>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411227 [details].
Comment 6 Radar WebKit Bug Importer 2020-10-14 07:01:20 PDT
<rdar://problem/70291022>