Bug 217657 – [LFC] Use the term overridden instead of override to indicate priority values

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

When a particular geometry value should be used instead of the computed value.

[zalan]

Created attachment 411227 [details]
Patch

[Antti Koivisto]

Comment on attachment 411227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411227&action=review

> Source/WebCore/ChangeLog:8
> +        The OverriddenHorizontal/Vertical structures are used to pass in priority values (e.g. use the "max-height" value instead of the computed "height" value) to geometry computation functions.

Overridden is still bit vague. Like why? Maybe there are more descriptive terms that could be used for these?

[zalan]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 411227 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=411227&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        The OverriddenHorizontal/Vertical structures are used to pass in priority values (e.g. use the "max-height" value instead of the computed "height" value) to geometry computation functions.
> 
> Overridden is still bit vague. Like why? Maybe there are more descriptive
> terms that could be used for these?
Yeah, I agree. Can't think of anything descriptive (and less than 1024 characters long) name right now though.

[zalan]

(In reply to zalan from comment #3)
> (In reply to Antti Koivisto from comment #2)
> > Comment on attachment 411227 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=411227&action=review
> > 
> > > Source/WebCore/ChangeLog:8
> > > +        The OverriddenHorizontal/Vertical structures are used to pass in priority values (e.g. use the "max-height" value instead of the computed "height" value) to geometry computation functions.
> > 
> > Overridden is still bit vague. Like why? Maybe there are more descriptive
> > terms that could be used for these?
> Yeah, I agree. Can't think of anything descriptive (and less than 1024
> characters long) name right now though.
The long name would be something like UseTheseValuesForCertainPropertiesInsteadOfTheirComputedValues

[EWS]

Committed r268456: <https://trac.webkit.org/changeset/268456>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411227 [details].

[Radar WebKit Bug Importer]

<rdar://problem/70291022>