Bug 217645 - [Testing] Support configuring any preference from test headers for WebKitTestRunner
Summary: [Testing] Support configuring any preference from test headers for WebKitTest...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-12 18:58 PDT by Sam Weinig
Modified: 2020-10-16 12:37 PDT (History)
27 users (show)

See Also:

Attachments
Patch (366.97 KB, patch)
2020-10-12 19:19 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (366.41 KB, patch)
2020-10-13 06:32 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (366.48 KB, patch)
2020-10-13 07:36 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (22.84 KB, patch)
2020-10-13 11:10 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (35.28 KB, patch)
2020-10-13 11:51 PDT, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (35.37 KB, patch)
2020-10-13 12:10 PDT, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (34.33 KB, patch)
2020-10-13 14:54 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (39.68 KB, patch)
2020-10-16 09:43 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-10-12 18:58:05 PDT 
[Testing] Support configuring any preference from test headers for WebKitTestRunner
Comment 1 Sam Weinig 2020-10-12 19:19:54 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-10-13 06:32:40 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-10-13 07:36:45 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2020-10-13 11:10:48 PDT Comment hidden (obsolete)
Comment 5 Sam Weinig 2020-10-13 11:51:51 PDT Comment hidden (obsolete)
Comment 6 Sam Weinig 2020-10-13 12:04:04 PDT Comment hidden (obsolete)
Comment 7 Sam Weinig 2020-10-13 12:10:37 PDT Comment hidden (obsolete)
Comment 8 Sam Weinig 2020-10-13 14:54:08 PDT 
Created attachment 411262 [details]
Patch
Comment 9 Sam Weinig 2020-10-13 21:11:41 PDT 
Ready for review.
Comment 10 EWS 2020-10-14 10:56:16 PDT 
Committed r268474: <https://trac.webkit.org/changeset/268474>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411262 [details].
Comment 11 Radar WebKit Bug Importer 2020-10-14 10:57:18 PDT 
<rdar://problem/70299567>
Comment 12 Hector Lopez 2020-10-14 16:21:15 PDT 
Reverted r268474 for reason:

Revision is causing a number of test failures across iOS and macOS

Committed r268498: <https://trac.webkit.org/changeset/268498>
Comment 13 Ryan Haddad 2020-10-14 16:27:25 PDT 
(In reply to Hector Lopez from comment #12)
> Reverted r268474 for reason:
> 
> Revision is causing a number of test failures across iOS and macOS
> 
> Committed r268498: <https://trac.webkit.org/changeset/268498>
Details in https://bugs.webkit.org/show_bug.cgi?id=217731
Comment 14 Sam Weinig 2020-10-16 09:43:55 PDT 
Created attachment 411588 [details]
Patch
Comment 15 EWS 2020-10-16 12:37:11 PDT 
Committed r268604: <https://trac.webkit.org/changeset/268604>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411588 [details].