Bug 217636 - JIT operations do not need extern "C"
Summary: JIT operations do not need extern "C"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-12 14:52 PDT by Yusuke Suzuki
Modified: 2020-10-12 21:53 PDT (History)
7 users (show)

See Also:


Attachments
Patch (13.64 KB, patch)
2020-10-12 14:53 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (13.14 KB, patch)
2020-10-12 14:55 PDT, Yusuke Suzuki
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (13.14 KB, patch)
2020-10-12 15:01 PDT, Yusuke Suzuki
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (13.22 KB, patch)
2020-10-12 15:40 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-10-12 14:52:22 PDT
JIT operations do not need extern "C"
Comment 1 Yusuke Suzuki 2020-10-12 14:53:30 PDT
Created attachment 411161 [details]
Patch
Comment 2 Yusuke Suzuki 2020-10-12 14:55:06 PDT
Created attachment 411164 [details]
Patch
Comment 3 Yusuke Suzuki 2020-10-12 14:57:28 PDT
Comment on attachment 411164 [details]
Patch

Oops, cleared Saam's r+ with the uploaded patch. But uploaded patch is just adding "// extern "C"" to MathCommons.cpp which original exists. So, I'll land this.
Comment 4 Yusuke Suzuki 2020-10-12 15:01:33 PDT
Created attachment 411166 [details]
Patch for landing
Comment 5 Yusuke Suzuki 2020-10-12 15:40:59 PDT
Created attachment 411175 [details]
Patch for landing
Comment 6 Yusuke Suzuki 2020-10-12 21:53:01 PDT
Committed r268385: <https://trac.webkit.org/changeset/268385>
Comment 7 Radar WebKit Bug Importer 2020-10-12 21:53:17 PDT
<rdar://problem/70238483>