Bug 217633 - Clean up the API tests of CARingBuffer
Summary: Clean up the API tests of CARingBuffer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-12 14:15 PDT by Peng Liu
Modified: 2020-10-13 09:57 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.48 KB, patch)
2020-10-12 14:18 PDT, Peng Liu 		no flags Details | Formatted Diff | Diff
Revise the patch according to Sam's comment (2.50 KB, patch)
2020-10-12 15:41 PDT, Peng Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2020-10-12 14:15:59 PDT 
Clean up the API tests of CARingBuffer
Comment 1 Peng Liu 2020-10-12 14:18:18 PDT 
Created attachment 411157 [details]
Patch
Comment 2 Sam Weinig 2020-10-12 14:53:01 PDT 
Comment on attachment 411157 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411157&action=review

> Tools/TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp:28
> +#if PLATFORM(COCOA)

Maybe HAVE(CORE_AUDIO) or HAVE(AUDIO_TOOLBOX) instead?
Comment 3 Peng Liu 2020-10-12 15:25:11 PDT 
Comment on attachment 411157 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411157&action=review

>> Tools/TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp:28
>> +#if PLATFORM(COCOA)
> 
> Maybe HAVE(CORE_AUDIO) or HAVE(AUDIO_TOOLBOX) instead?

Yes, good point! Thanks!
Comment 4 Peng Liu 2020-10-12 15:41:59 PDT 
Created attachment 411176 [details]
Revise the patch according to Sam's comment
Comment 5 EWS 2020-10-13 09:56:42 PDT 
Committed r268397: <https://trac.webkit.org/changeset/268397>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411176 [details].
Comment 6 Radar WebKit Bug Importer 2020-10-13 09:57:15 PDT 
<rdar://problem/70256224>