Bug 217627 – CSSStyleDeclaration includes descriptors

• Status: NEW
• Component: CSS

[Sam Sneddon [:gsnedders]]

e.g.:

> "unicode-range" in document.body.style
< true

CSSStyleDeclaration should just contain properties, not descriptors.

[Sam Sneddon [:gsnedders]]

If you want more to fix around CSSStyleDeclaration Sam, there's more :)

CSS.supports gets this right, but the IDL generation doesn't.

[Sam Weinig]

Sam, can you point me to where the difference between properties and descriptors is defined? Our current CSSProperties.json does not seem to differentiate (or I don't understand how it is), so I would need a better understanding of what to change.

[Sam Sneddon [:gsnedders]]

Sam, I filed https://github.com/w3c/csswg-drafts/issues/5633 about the fact that this is pretty unclear currently.

A bunch of these have "skip-builder": true currently, so maybe we just want that more?

[Radar WebKit Bug Importer]

<rdar://problem/70449709>

[Sam Weinig]

(In reply to Sam Sneddon [:gsnedders] from comment #3)
> Sam, I filed https://github.com/w3c/csswg-drafts/issues/5633 about the fact
> that this is pretty unclear currently.
> 
> A bunch of these have "skip-builder": true currently, so maybe we just want
> that more?

There are ~40 marked with "skip-builder". If that is the set, perhaps we can rename skip-builder to be something semantic about the property rather than an action and use it, but I am not clear if that is the correct set.

[Sam Weinig]

Created attachment 412038 [details]
Patch

[Sam Weinig]

Turns out there was a function on CSSProperty called isDescriptorOnly, so I'm going to use that as the guide.

[Sam Weinig]

Hm, seems at least on rest expects some descriptors sometimes.

[Sam Weinig]

The test, imported/w3c/web-platform-tests/css/cssom/cssom-fontfacerule.html, seems to indicate that when you get a CSSStyleDeclaration from a CSSFontFaceRule, it should include the descriptor "src".

[Sam Weinig]

Reseting to default assignee while we work out what the behavior here should really be.

[Sam Sneddon [:gsnedders]]

(In reply to Sam Weinig from comment #9)
> The test, imported/w3c/web-platform-tests/css/cssom/cssom-fontfacerule.html,
> seems to indicate that when you get a CSSStyleDeclaration from a
> CSSFontFaceRule, it should include the descriptor "src".

(In reply to Sam Weinig from comment #10)
> Reseting to default assignee while we work out what the behavior here should
> really be.

See also: https://github.com/w3c/csswg-drafts/issues/5649