Bug 217603 - Remove ACCELERATED_2D_CANVAS build flags and guarded code
Summary: Remove ACCELERATED_2D_CANVAS build flags and guarded code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-12 02:01 PDT by Zan Dobersek
Modified: 2020-10-14 11:13 PDT (History)
31 users (show)

See Also:

Attachments
WIP (66.63 KB, patch)
2020-10-12 02:02 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (78.06 KB, patch)
2020-10-12 11:40 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch for landing (78.15 KB, patch)
2020-10-13 04:29 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2020-10-12 02:01:33 PDT 
Remove ACCELERATED_2D_CANVAS build flags and guarded code
Comment 1 Zan Dobersek 2020-10-12 02:02:13 PDT 
Created attachment 411104 [details]
WIP
Comment 2 Konstantin Tokarev 2020-10-12 03:30:41 PDT 
It would be great if there was some justification in changelog, as it's not removing obviously dead code
Comment 3 Zan Dobersek 2020-10-12 11:40:04 PDT 
Created attachment 411138 [details]
Patch
Comment 4 Carlos Garcia Campos 2020-10-13 01:12:29 PDT 
Comment on attachment 411138 [details]
Patch

I guess this needs to be rebased
Comment 5 Zan Dobersek 2020-10-13 04:29:10 PDT 
Created attachment 411210 [details]
Patch for landing
Comment 6 Michael Catanzaro 2020-10-13 07:23:57 PDT 
(In reply to Konstantin Tokarev from comment #2)
> It would be great if there was some justification in changelog, as it's not
> removing obviously dead code

The updated changelog looks better. Also note it's been disabled by default everywhere since bug #148473. Probably long past time to remove it.
Comment 7 Adrian Perez 2020-10-13 07:53:37 PDT 
*** Bug 208523 has been marked as a duplicate of this bug. ***
Comment 8 Zan Dobersek 2020-10-14 05:06:35 PDT 
Comment on attachment 411210 [details]
Patch for landing

Clearing flags on attachment: 411210

Committed r268453: <https://trac.webkit.org/changeset/268453>
Comment 9 Zan Dobersek 2020-10-14 05:06:40 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2020-10-14 05:07:19 PDT 
<rdar://problem/70288514>