Bug 217602 - [macOS] Workaround for MAC_OS_X_VERSION_MAJOR incorrectly including minor version when building with Xcode 12 on macOS Big Sur SUs
Summary: [macOS] Workaround for MAC_OS_X_VERSION_MAJOR incorrectly including minor ver...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Safari Technology Preview
Hardware: Macintosh Unspecified
: P1 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-10-11 23:56 PDT by Luming Yin
Modified: 2020-10-12 15:09 PDT (History)
16 users (show)

See Also:


Attachments
Patch (42.14 KB, patch)
2020-10-12 00:04 PDT, Luming Yin
no flags Details | Formatted Diff | Diff
Patch (45.20 KB, patch)
2020-10-12 00:58 PDT, Luming Yin
no flags Details | Formatted Diff | Diff
Patch (50.41 KB, patch)
2020-10-12 14:14 PDT, Luming Yin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luming Yin 2020-10-11 23:56:47 PDT
<rdar://problem/70194453>
Comment 1 Luming Yin 2020-10-12 00:04:06 PDT
Created attachment 411097 [details]
Patch
Comment 2 EWS Watchlist 2020-10-12 00:05:24 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Luming Yin 2020-10-12 00:58:36 PDT
Created attachment 411100 [details]
Patch
Comment 4 EWS 2020-10-12 09:27:23 PDT
Committed r268353: <https://trac.webkit.org/changeset/268353>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411100 [details].
Comment 5 Luming Yin 2020-10-12 14:05:04 PDT
This needs another patch. Reopening.
Comment 6 Luming Yin 2020-10-12 14:14:46 PDT
Created attachment 411156 [details]
Patch
Comment 7 Darin Adler 2020-10-12 14:35:53 PDT
Comment on attachment 411156 [details]
Patch

Ah, so my question wasn’t so pointless after all!
Comment 8 Luming Yin 2020-10-12 15:08:15 PDT
(In reply to Darin Adler from comment #7)
> Comment on attachment 411156 [details]
> Patch
> 
> Ah, so my question wasn’t so pointless after all!

Indeed!
Comment 9 EWS 2020-10-12 15:09:41 PDT
Committed r268371: <https://trac.webkit.org/changeset/268371>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411156 [details].