RESOLVED FIXED 217602
[macOS] Workaround for MAC_OS_X_VERSION_MAJOR incorrectly including minor version when building with Xcode 12 on macOS Big Sur SUs 
https://bugs.webkit.org/show_bug.cgi?id=217602
Summary [macOS] Workaround for MAC_OS_X_VERSION_MAJOR incorrectly including minor ver...
Luming Yin
Reported 2020-10-11 23:56:47 PDT
<rdar://problem/70194453>
Attachments
Patch (42.14 KB, patch)
2020-10-12 00:04 PDT, Luming Yin 		no flags
DetailsFormatted DiffDiff
Patch (45.20 KB, patch)
2020-10-12 00:58 PDT, Luming Yin 		no flags
DetailsFormatted DiffDiff
Patch (50.41 KB, patch)
2020-10-12 14:14 PDT, Luming Yin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Luming Yin
Comment 1 2020-10-12 00:04:06 PDT
Created attachment 411097 [details] Patch
EWS Watchlist
Comment 2 2020-10-12 00:05:24 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Luming Yin
Comment 3 2020-10-12 00:58:36 PDT
Created attachment 411100 [details] Patch
EWS
Comment 4 2020-10-12 09:27:23 PDT
Committed r268353: <https://trac.webkit.org/changeset/268353> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411100 [details].
Luming Yin
Comment 5 2020-10-12 14:05:04 PDT
This needs another patch. Reopening.
Luming Yin
Comment 6 2020-10-12 14:14:46 PDT
Created attachment 411156 [details] Patch
Darin Adler
Comment 7 2020-10-12 14:35:53 PDT
Comment on attachment 411156 [details] Patch Ah, so my question wasn’t so pointless after all!
Luming Yin
Comment 8 2020-10-12 15:08:15 PDT
(In reply to Darin Adler from comment #7) > Comment on attachment 411156 [details] > Patch > > Ah, so my question wasn’t so pointless after all! Indeed!
EWS
Comment 9 2020-10-12 15:09:41 PDT
Committed r268371: <https://trac.webkit.org/changeset/268371> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411156 [details].
Note You need to log in before you can comment on or make changes to this bug.